From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 2BBB91FF15E for ; Tue, 3 Jun 2025 20:56:14 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 0A0C51EE6D; Tue, 3 Jun 2025 20:56:31 +0200 (CEST) From: Thomas Lamprecht To: pve-devel@lists.proxmox.com, Dominik Csapak Date: Tue, 3 Jun 2025 20:56:23 +0200 Message-Id: <174897697269.3070212.1186761723593651830.b4-ty@proxmox.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250603085247.917673-1-d.csapak@proxmox.com> References: <20250603085247.917673-1-d.csapak@proxmox.com> MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.035 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] applied: [PATCH mini-journalreader v3] fix #6410: properly close json output on error X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" On Tue, 03 Jun 2025 10:52:47 +0200, Dominik Csapak wrote: > when encountering an error (e.g. there was no curser at the wanted > position), the program would close with exitcode 1, but would not > properly finish the json output if in json mode. > > To fix that, introduce a `print_error_and_exit` helper that tries to > finish the json output. We set `success` to 0 to indicate an error. > > [...] Applied, thanks! [1/1] fix #6410: properly close json output on error commit: a1d86b7e6526351b6513f516a661acce33d1b64d _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel