From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 8D58D1FF187 for ; Mon, 26 May 2025 17:28:37 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 99F6F357BE; Mon, 26 May 2025 17:28:50 +0200 (CEST) From: Thomas Lamprecht To: pve-devel@lists.proxmox.com, Lukas Wagner Date: Mon, 26 May 2025 17:17:58 +0200 Message-ID: <174827266939.3667152.5085625450943814820.b4-ty@proxmox.com> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250526134211.278900-1-l.wagner@proxmox.com> References: <20250526134211.278900-1-l.wagner@proxmox.com> MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.035 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_SHORT 0.001 Use of a URL Shortener for very short URL RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] applied: [PATCH proxmox] sendmail: fix test failures outside CET/CEST timezones X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" On Mon, 26 May 2025 15:42:11 +0200, Lukas Wagner wrote: > The `Date` header in the generated email includes a timestamp with a > time zone offset (RFC 2822 format). This causes test failures when the > host system's time zone differs from CET/CEST, as the expected and > actual outputs no longer match. > > As a workaround, the `Date` header is excluded from comparisons between > the generated and reference emails. It's really fine as workaround; in the long term we might want to parse and normalize the datetime values before comparision, but as we have no RFC 2822 parser available here we would either add that to proxmox-time, or evaluate if the newer and (from a shallow research) saner Jiff [0] crate would work for us, especially for cases where chrono failed (IIRC, panics, but might have been other stuff). Anyhow, the rfc2822 helper we use to render the epoch is not in this crate here, so it isn't really its job to test that function, and tbh. it's unlikely that we manage to introduce a regression for the date mail headers in this rather simple case. Meaning, there's really no priority to "fix" this, but if we ever got a RFC 2822 parser available here anyway it might as well be used here too. [0]: https://docs.rs/jiff/latest/jiff/#parsing-an-rfc-2822-datetime-string > > [...] Applied, thanks! [1/1] sendmail: fix test failures outside CET/CEST timezones commit: 972e0844dc49fdf12a77ba6597a5ee6ddf1fc23a _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel