From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id F156E1FF16E for ; Mon, 17 Mar 2025 16:18:50 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id A80197328; Mon, 17 Mar 2025 16:18:40 +0100 (CET) Date: Mon, 17 Mar 2025 16:18:04 +0100 From: Fabian =?iso-8859-1?q?Gr=FCnbichler?= To: Proxmox Backup Server development discussion References: <20250221141719.392683-1-c.ebner@proxmox.com> In-Reply-To: <20250221141719.392683-1-c.ebner@proxmox.com> MIME-Version: 1.0 User-Agent: astroid/0.16.0 (https://github.com/astroidmail/astroid) Message-Id: <1742224310.w3aml8s8r9.astroid@yuna.none> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.043 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox.com, main.rs] Subject: Re: [pbs-devel] [PATCH v3 proxmox-backup] fix #6185: client/docs: explicitly mention archive name restrictions X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" On February 21, 2025 3:17 pm, Christian Ebner wrote: > Mention in the docs and the api parameter description the limitations > for archive name labels. They must contain alphanumerics, hyphens and > underscores only to match the regex pattern. > > Further, explicitly mention the extension in the backup source schema > specification, to clearly distinguish this from the label and be in > line with the description give in the schema for the cli command. > > By setting this in the api parameter description, it will be included > in the man page for proxmox-backup-client. > > Fixes: https://bugzilla.proxmox.com/show_bug.cgi?id=6185 > Signed-off-by: Christian Ebner > --- > changes since version 2: > - Also explicitly mention the extension part in the backup source > schema description, thanks @Shannon for noticing! > - Adapt commit message accordingly > > docs/backup-client.rst | 1 + > pbs-client/src/backup_specification.rs | 10 ++++++---- > proxmox-backup-client/src/main.rs | 3 ++- > 3 files changed, 9 insertions(+), 5 deletions(-) > > diff --git a/docs/backup-client.rst b/docs/backup-client.rst > index 1c2a98ed8..e11c0142a 100644 > --- a/docs/backup-client.rst > +++ b/docs/backup-client.rst > @@ -169,6 +169,7 @@ the client. The format is: > > .: > > +The ``archive-name`` must contain alphanumerics, hyphens and underscores only. > Common types are ``.pxar`` for file archives and ``.img`` for block > device images. To create a backup of a block device, run the following command: here we call it archive-name, type and source-path, but > > diff --git a/pbs-client/src/backup_specification.rs b/pbs-client/src/backup_specification.rs > index b6fbc555c..fe5c352e4 100644 > --- a/pbs-client/src/backup_specification.rs > +++ b/pbs-client/src/backup_specification.rs > @@ -7,10 +7,12 @@ const_regex! { > BACKUPSPEC_REGEX = r"^([a-zA-Z0-9_-]+\.(pxar|img|conf|log)):(.+)$"; > } > > -pub const BACKUP_SOURCE_SCHEMA: Schema = > - StringSchema::new("Backup source specification ([