From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id DE0891FF15C for ; Wed, 5 Mar 2025 10:42:12 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id EF1691105C; Wed, 5 Mar 2025 10:42:08 +0100 (CET) Date: Wed, 05 Mar 2025 10:41:32 +0100 From: Fabian =?iso-8859-1?q?Gr=FCnbichler?= To: Proxmox Backup Server development discussion References: <20250304183546.461918-1-c.ebner@proxmox.com> <20250304183546.461918-4-c.ebner@proxmox.com> In-Reply-To: <20250304183546.461918-4-c.ebner@proxmox.com> MIME-Version: 1.0 User-Agent: astroid/0.16.0 (https://github.com/astroidmail/astroid) Message-Id: <1741165277.s9t9jfl3wk.astroid@yuna.none> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.045 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pbs-devel] applied: [PATCH v3 proxmox-backup 3/9] datastore: use libc's timespec constants instead of redefinition X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" applied this one already :) On March 4, 2025 7:35 pm, Christian Ebner wrote: > Use the UTIME_NOW and UTIME_OMIT constants defined in libc crate > instead of redefining them. This improves consistency, as utimesat > and its timespec parameter are also defined via the libc crate. > > Signed-off-by: Christian Ebner > --- > changes since version 2: > - use libc's constants instead of re-defining them > > pbs-datastore/src/chunk_store.rs | 7 ++----- > 1 file changed, 2 insertions(+), 5 deletions(-) > > diff --git a/pbs-datastore/src/chunk_store.rs b/pbs-datastore/src/chunk_store.rs > index 29d5874a1..5e02909a1 100644 > --- a/pbs-datastore/src/chunk_store.rs > +++ b/pbs-datastore/src/chunk_store.rs > @@ -220,19 +220,16 @@ impl ChunkStore { > // unwrap: only `None` in unit tests > assert!(self.locker.is_some()); > > - const UTIME_NOW: i64 = (1 << 30) - 1; > - const UTIME_OMIT: i64 = (1 << 30) - 2; > - > let times: [libc::timespec; 2] = [ > // access time -> update to now > libc::timespec { > tv_sec: 0, > - tv_nsec: UTIME_NOW, > + tv_nsec: libc::UTIME_NOW, > }, > // modification time -> keep as is > libc::timespec { > tv_sec: 0, > - tv_nsec: UTIME_OMIT, > + tv_nsec: libc::UTIME_OMIT, > }, > ]; > > -- > 2.39.5 > > > > _______________________________________________ > pbs-devel mailing list > pbs-devel@lists.proxmox.com > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel > > > _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel