From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id DB1DD1FF15C for ; Wed, 5 Mar 2025 10:42:23 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 0D839110F5; Wed, 5 Mar 2025 10:42:20 +0100 (CET) Date: Wed, 05 Mar 2025 10:41:44 +0100 From: Fabian =?iso-8859-1?q?Gr=FCnbichler?= To: Proxmox Backup Server development discussion References: <20250304183546.461918-1-c.ebner@proxmox.com> In-Reply-To: <20250304183546.461918-1-c.ebner@proxmox.com> MIME-Version: 1.0 User-Agent: astroid/0.16.0 (https://github.com/astroidmail/astroid) Message-Id: <1741162723.0nyctto9gv.astroid@yuna.none> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.045 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pbs-devel] [PATCH v3 proxmox-backup 0/9] fix #5982: check atime update is honored X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" On March 4, 2025 7:35 pm, Christian Ebner wrote: > These patches add a check to phase 1 of garbage collection in order > to detect when the filesystem backing the chunk store does not honor > atime updates. This avoids possible data loss for situations where > garbage collection could otherwise delete chunks still referenced by > a backup snaphost's index file. > > The check is performed by inserting a fixed size 4 MiB unencrypted and > compressed chunk of all-zeros. The check is performed by setting the > atime to 1 second in the past followed by setting it to now in order to > test if atime updates are honored immediately. The test is performed > on datastore creation for early detection and before garbage collection > phase 1. The test is enabled by default, but an opt-out option can be > set via the datastore tuning parameters for backwards compatibility. this is outdated ;) > > Further, add a datastore tuning parameter to reduce the wait period for > chunk removal in phase 2 of garbage collection. Make this conditional on > the atime update check being enabled and successful, to avoid possible > data loss. > > Most notable changes sice version 1 (thanks Fabian and Thomas for > comments and suggestions): > - Take into account Linux timestamp granularity, do not set timestamp > to the past, as that introduces other error paths such as lack of > permissions or fs limitations. > - Check relatime behavior, if atime behaviour is not honored. Fallback > to original cutoff in that case. > - Adapt tuning parameter names. but here it is correct :) > > Most notable changes sice version 1 (thanks Fabian and Thomas for > comments and suggestions): > - Optimize check by using the all zero chunk > - Enable the check by default and fail GC job if not honored, but allow > to opt-out > - Add GC wait period tuning option > > Link to the issue in the bugtracker: > https://bugzilla.proxmox.com/show_bug.cgi?id=5982 > > proxmox: > > Christian Ebner (2): > pbs api types: add garbage collection atime safety check flag > pbs api types: add option to set GC chunk cleanup atime cutoff > > pbs-api-types/src/datastore.rs | 25 +++++++++++++++++++++++++ > 1 file changed, 25 insertions(+) > > proxmox-backup: > > Christian Ebner (7): > datastore: use libc's timespec constants instead of redefinition > fix #5982: garbage collection: check atime updates are honored > ui: expose GC atime safety check flag in datastore tuning options > docs: mention GC atime update check for tuning options > datastore: conditionally use custom GC atime cutoff if set > ui: expose GC atime cutoff in datastore tuning option > docs: mention gc-atime-cutoff as datastore tuning option > > docs/storage.rst | 19 +++- > pbs-datastore/src/chunk_store.rs | 144 ++++++++++++++++++++++++++++--- > pbs-datastore/src/datastore.rs | 32 +++++++ > src/api2/config/datastore.rs | 1 + > www/Utils.js | 9 ++ > www/datastore/OptionView.js | 17 ++++ > 6 files changed, 208 insertions(+), 14 deletions(-) > > -- > 2.39.5 > > > > _______________________________________________ > pbs-devel mailing list > pbs-devel@lists.proxmox.com > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel > > > _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel