From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id E83F41FF15C for ; Wed, 5 Mar 2025 08:58:20 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 5CCAAE8B6; Wed, 5 Mar 2025 08:58:16 +0100 (CET) Date: Wed, 05 Mar 2025 08:57:40 +0100 From: Fabian =?iso-8859-1?q?Gr=FCnbichler?= To: Christian Ebner , Proxmox Backup Server development discussion , Thomas Lamprecht References: <20250219164847.757184-1-c.ebner@proxmox.com> <20250219164847.757184-3-c.ebner@proxmox.com> <1741005633.eo593uhjhw.astroid@yuna.none> <1151f4cb-36f2-4bb7-9e15-1d52850cc23a@proxmox.com> <7c0d6e54-1f71-4c05-b4f6-00779b8d2673@proxmox.com> In-Reply-To: <7c0d6e54-1f71-4c05-b4f6-00779b8d2673@proxmox.com> MIME-Version: 1.0 User-Agent: astroid/0.16.0 (https://github.com/astroidmail/astroid) Message-Id: <1741161268.p5t203w27h.astroid@yuna.none> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.045 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pbs-devel] [PATCH proxmox 2/2] pbs api types: add option to set GC chunk cleanup wait period X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" On March 4, 2025 5:49 pm, Thomas Lamprecht wrote: > Am 04.03.25 um 17:37 schrieb Christian Ebner: >> Also, there will be no upper limit for the gc-atime-safety-margin, as >> Fabian pointed out correctly, setting this to large values might be >> desired to avoid data loss if something is off, and one notices from >> e.g. the pending removals. > > I'm rather a fan of _some_ limits even if only to be proven wrong by user > demand to go over that, but then we actually know the use case. As until > now we got no request at all for this to be higher, IIRC, I'd go for two > days. > > Data loss is prevented by additional copies on other servers and mediums > (keyword: tape or soon s3) not some rather internal GC cut-off that > provides no nice mechanism to recover any data from it, so I also do > not really buy that it will be used as that in practice, we certainly > should not advertise it as candidate for that. that's true, keeping the chunks for a longer period just makes recovering from an accidental "over-pruning" much faster (by syncing just the metadata back from whichever offsite copy), it doesn't allow recovering on its own without an extra copy. so if your datastore has the headroom, bumping the limit to a week for example and monitoring your GC stats to notice pending removal outliers can save you days of copying chunks back.. it's probably not a very common use case though, and temporarily or permanently reducing it down to a very low bound will probably be the common (and maybe future default) setting ;) _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel