From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 42A161FF16E for ; Mon, 3 Mar 2025 14:04:26 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id DEAB4A767; Mon, 3 Mar 2025 14:04:22 +0100 (CET) Date: Mon, 03 Mar 2025 14:03:45 +0100 From: Fabian =?iso-8859-1?q?Gr=FCnbichler?= To: Proxmox Backup Server development discussion References: <20250219164847.757184-1-c.ebner@proxmox.com> <20250219164847.757184-4-c.ebner@proxmox.com> In-Reply-To: <20250219164847.757184-4-c.ebner@proxmox.com> MIME-Version: 1.0 User-Agent: astroid/0.16.0 (https://github.com/astroidmail/astroid) Message-Id: <1741006715.wznd1a41xh.astroid@yuna.none> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.045 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pbs-devel] [PATCH proxmox-backup 3/9] datastore: move utimensat() related constants to module scope X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" On February 19, 2025 5:48 pm, Christian Ebner wrote: > Move the UTIME_NOW and UTIME_OMIT constants from the current function > scope to the module scope in order to allow to reuse them. > > This is in preparation for adding a check to test if the filesystem > backing the chunk store honors immediate atime updates by calling > utimensat(). > > Signed-off-by: Christian Ebner > --- > changes since version 1: > - not present in previous version > > pbs-datastore/src/chunk_store.rs | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/pbs-datastore/src/chunk_store.rs b/pbs-datastore/src/chunk_store.rs > index 29d5874a1..7bdcb0297 100644 > --- a/pbs-datastore/src/chunk_store.rs > +++ b/pbs-datastore/src/chunk_store.rs > @@ -18,6 +18,9 @@ use crate::file_formats::{ > }; > use crate::DataBlob; > > +const UTIME_NOW: i64 = (1 << 30) - 1; > +const UTIME_OMIT: i64 = (1 << 30) - 2; these are exported by libc, couldn't we just use the definition from there? > + > /// File system based chunk store > pub struct ChunkStore { > name: String, // used for error reporting > @@ -220,9 +223,6 @@ impl ChunkStore { > // unwrap: only `None` in unit tests > assert!(self.locker.is_some()); > > - const UTIME_NOW: i64 = (1 << 30) - 1; > - const UTIME_OMIT: i64 = (1 << 30) - 2; > - > let times: [libc::timespec; 2] = [ > // access time -> update to now > libc::timespec { > -- > 2.39.5 > > > > _______________________________________________ > pbs-devel mailing list > pbs-devel@lists.proxmox.com > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel > > > _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel