From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pbs-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
	by lore.proxmox.com (Postfix) with ESMTPS id DA97D1FF2CF
	for <inbox@lore.proxmox.com>; Thu, 11 Jul 2024 10:50:19 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
	by firstgate.proxmox.com (Proxmox) with ESMTP id AA6F41FC95;
	Thu, 11 Jul 2024 10:50:43 +0200 (CEST)
MIME-Version: 1.0
In-Reply-To: <20240710145732.142784-1-f.schauer@proxmox.com>
References: <20240710145732.142784-1-f.schauer@proxmox.com>
From: Fabian =?utf-8?q?Gr=C3=BCnbichler?= <f.gruenbichler@proxmox.com>
To: Proxmox Backup Server development discussion <pbs-devel@lists.proxmox.com>
Date: Thu, 11 Jul 2024 10:50:04 +0200
Message-ID: <172068780438.109383.3815056544992095597@yuna.proxmox.com>
User-Agent: alot/0.10
X-SPAM-LEVEL: Spam detection results:  0
 AWL 0.050 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 DMARC_MISSING             0.1 Missing DMARC policy
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_PASS               -0.001 SPF: sender matches SPF record
Subject: [pbs-devel] applied-series: [PATCH vma-to-pbs v3 0/2] add support
 for notes and logs
X-BeenThere: pbs-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox Backup Server development discussion
 <pbs-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pbs-devel>, 
 <mailto:pbs-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pbs-devel/>
List-Post: <mailto:pbs-devel@lists.proxmox.com>
List-Help: <mailto:pbs-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel>, 
 <mailto:pbs-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Proxmox Backup Server development discussion
 <pbs-devel@lists.proxmox.com>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: pbs-devel-bounces@lists.proxmox.com
Sender: "pbs-devel" <pbs-devel-bounces@lists.proxmox.com>

I still hope we manage to extract the backup client properly at some point..

Quoting Filip Schauer (2024-07-10 16:57:30)
> Changes since v2:
> * Split the create_pbs_backup_task argument change into its own commit
> * Create the HttpClient directly to avoid writing the password into an
>   environment variable
> * Put the client setup into its own helper function and call it from
>   backup_vma_to_pbs along with set_notes and upload_log
> 
> Changes since v1:
> * Set notes and upload log separately via a new connection to the API,
>   instead of hacking notes into the proxmox-backup-qemu C functions and
>   uploading the log as a config.
> 
> vma-to-pbs:
> 
> Filip Schauer (2):
>   pass args by reference to create_pbs_backup_task
>   add support for notes and logs
> 
>  Cargo.toml     |   8 +++
>  src/main.rs    |  16 ++++++
>  src/vma2pbs.rs | 133 +++++++++++++++++++++++++++++++++++++++++++++----
>  3 files changed, 147 insertions(+), 10 deletions(-)
> 
> 
> Summary over all repositories:
>   3 files changed, 147 insertions(+), 10 deletions(-)
> 
> -- 
> Generated by git-murpp 0.6.0
> 
> 
> _______________________________________________
> pbs-devel mailing list
> pbs-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
> 
>


_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel