From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id BA9971FF2AA for ; Wed, 3 Jul 2024 15:33:17 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id BE8638FD4; Wed, 3 Jul 2024 15:33:31 +0200 (CEST) Date: Wed, 03 Jul 2024 15:32:54 +0200 From: Fabian =?iso-8859-1?q?Gr=FCnbichler?= To: Proxmox VE development discussion References: <20240528085005.45859-1-f.ebner@proxmox.com> <20240528085005.45859-4-f.ebner@proxmox.com> In-Reply-To: <20240528085005.45859-4-f.ebner@proxmox.com> MIME-Version: 1.0 User-Agent: astroid/0.16.0 (https://github.com/astroidmail/astroid) Message-Id: <1720013543.j93io9ggfx.astroid@yuna.none> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.051 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox.com, qemumigrate.pm, machine.pm, qemumigratemock.pm, qmphelpers.pm] Subject: Re: [pve-devel] [RFC v2 qemu-server 4/4] move helper to check running QEMU version out of the 'Machine' module X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" T24gTWF5IDI4LCAyMDI0IDEwOjUwIGFtLCBGaW9uYSBFYm5lciB3cm90ZToKPiBUaGUgdmVyc2lv biBvZiB0aGUgcnVubmluZyBRRU1VIGJpbmFyeSBpcyBub3QgcmVsYXRlZCB0byB0aGUgbWFjaGlu ZQo+IHZlcnNpb24gYW5kIHNvIGl0J3MgYSBiaXQgY29uZnVzaW5nIHRvIGhhdmUgdGhlIGhlbHBl ciBpbiB0aGUKPiAnTWFjaGluZScgbW9kdWxlLiBJdCBjYW5ub3QgbGl2ZSBpbiB0aGUgJ0hlbHBl cnMnIG1vZHVsZSwgYmVjYXVzZSB0aGF0Cj4gd291bGQgbGVhZCB0byBhIGN5Y2xpYyBpbmNsdXNp b24gSGVscGVycyA8LT4gTW9uaXRvci4gVGh1cywKPiAnUU1QSGVscGVycycgaXMgY2hvc2VuIGFz IHRoZSBuZXcgaG9tZS4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBGaW9uYSBFYm5lciA8Zi5lYm5lckBw cm94bW94LmNvbT4KCkFja2VkLWJ5OiBGYWJpYW4gR3LDvG5iaWNobGVyIDxmLmdydWVuYmljaGxl ckBwcm94bW94LmNvbT4KCmJ1dCBuZWVkcyB0aGUgZmlyc3QgcGF0Y2ggdG8gYmUgYXBwbGllZCwg b3IgYSByZS1vcmRlciB0byBtb3ZlIHRoaXMKZmlyc3QgOykKCj4gLS0tCj4gCj4gTmV3IGluIHYy Lgo+IAo+ICBQVkUvUWVtdU1pZ3JhdGUucG0gICAgICAgICAgICAgICAgICAgIHwgIDMgKystCj4g IFBWRS9RZW11U2VydmVyL01hY2hpbmUucG0gICAgICAgICAgICAgfCAxMiAtLS0tLS0tLS0tLS0K PiAgUFZFL1FlbXVTZXJ2ZXIvUU1QSGVscGVycy5wbSAgICAgICAgICB8IDEzICsrKysrKysrKysr KysKPiAgdGVzdC9NaWdyYXRpb25UZXN0L1FlbXVNaWdyYXRlTW9jay5wbSB8ICA0ICsrKysKPiAg dGVzdC9ydW5fY29uZmlnMmNvbW1hbmRfdGVzdHMucGwgICAgICB8ICA0ICsrLS0KPiAgNSBmaWxl cyBjaGFuZ2VkLCAyMSBpbnNlcnRpb25zKCspLCAxNSBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0t Z2l0IGEvUFZFL1FlbXVNaWdyYXRlLnBtIGIvUFZFL1FlbXVNaWdyYXRlLnBtCj4gaW5kZXggMzRm YzQ2ZWUuLmU3MWZhY2U0IDEwMDY0NAo+IC0tLSBhL1BWRS9RZW11TWlncmF0ZS5wbQo+ICsrKyBi L1BWRS9RZW11TWlncmF0ZS5wbQo+IEBAIC0zMCw2ICszMCw3IEBAIHVzZSBQVkU6OlFlbXVTZXJ2 ZXI6OkhlbHBlcnMgcXcobWluX3ZlcnNpb24pOwo+ICB1c2UgUFZFOjpRZW11U2VydmVyOjpNYWNo aW5lOwo+ICB1c2UgUFZFOjpRZW11U2VydmVyOjpNb25pdG9yIHF3KG1vbl9jbWQpOwo+ICB1c2Ug UFZFOjpRZW11U2VydmVyOjpNZW1vcnkgcXcoZ2V0X2N1cnJlbnRfbWVtb3J5KTsKPiArdXNlIFBW RTo6UWVtdVNlcnZlcjo6UU1QSGVscGVyczsKPiAgdXNlIFBWRTo6UWVtdVNlcnZlcjsKPiAgCj4g IHVzZSBQVkU6OkFic3RyYWN0TWlncmF0ZTsKPiBAQCAtMTE0MCw3ICsxMTQxLDcgQEAgc3ViIHBo YXNlMiB7Cj4gIAkgICAgUFZFOjpRZW11U2VydmVyOjpxZW11X2RyaXZlX21pcnJvcigkdm1pZCwg JGRyaXZlLCAkbmJkX3VyaSwgJHZtaWQsIHVuZGVmLCAkc2VsZi0+e3N0b3JhZ2VfbWlncmF0aW9u X2pvYnN9LCAnc2tpcCcsIHVuZGVmLCAkYndsaW1pdCwgJGJpdG1hcCk7Cj4gIAl9Cj4gIAo+IC0J aWYgKFBWRTo6UWVtdVNlcnZlcjo6TWFjaGluZTo6cnVuc19hdF9sZWFzdF9xZW11X3ZlcnNpb24o JHZtaWQsIDgsIDIpKSB7Cj4gKwlpZiAoUFZFOjpRZW11U2VydmVyOjpRTVBIZWxwZXJzOjpydW5z X2F0X2xlYXN0X3FlbXVfdmVyc2lvbigkdm1pZCwgOCwgMikpIHsKPiAgCSAgICAkc2VsZi0+bG9n KCdpbmZvJywgInN3aXRjaGluZyBtaXJyb3Igam9icyB0byBhY3RpdmVseSBzeW5jZWQgbW9kZSIp Owo+ICAJICAgIFBWRTo6UWVtdVNlcnZlcjo6cWVtdV9kcml2ZV9taXJyb3Jfc3dpdGNoX3RvX2Fj dGl2ZV9tb2RlKAo+ICAJCSR2bWlkLAo+IGRpZmYgLS1naXQgYS9QVkUvUWVtdVNlcnZlci9NYWNo aW5lLnBtIGIvUFZFL1FlbXVTZXJ2ZXIvTWFjaGluZS5wbQo+IGluZGV4IGNjOTJlN2U2Li5hMzkx N2RhZSAxMDA2NDQKPiAtLS0gYS9QVkUvUWVtdVNlcnZlci9NYWNoaW5lLnBtCj4gKysrIGIvUFZF L1FlbXVTZXJ2ZXIvTWFjaGluZS5wbQo+IEBAIC0xNjEsMTggKzE2MSw2IEBAIHN1YiBjYW5fcnVu X3B2ZV9tYWNoaW5lX3ZlcnNpb24gewo+ICAgICAgcmV0dXJuIDA7Cj4gIH0KPiAgCj4gLSMgZGll cyBpZiBhKSBWTSBub3QgcnVubmluZyBvciBub3QgZXhpc2l0aW5nIGIpIFZlcnNpb24gcXVlcnkg ZmFpbGVkCj4gLSMgU28sIGFueSBkZWZpbmVkIHJldHVybiB2YWx1ZSBpcyB2YWxpZCwgYW55IGlu dmFsaWQgc3RhdGUgY2FuIGJlIGNhdWdodCBieSBldmFsCj4gLXN1YiBydW5zX2F0X2xlYXN0X3Fl bXVfdmVyc2lvbiB7Cj4gLSAgICBteSAoJHZtaWQsICRtYWpvciwgJG1pbm9yLCAkZXh0cmEpID0g QF87Cj4gLQo+IC0gICAgbXkgJHYgPSBQVkU6OlFlbXVTZXJ2ZXI6Ok1vbml0b3I6Om1vbl9jbWQo JHZtaWQsICdxdWVyeS12ZXJzaW9uJyk7Cj4gLSAgICBkaWUgImNvdWxkIG5vdCBxdWVyeSBjdXJy ZW50bHkgcnVubmluZyB2ZXJzaW9uIGZvciBWTSAkdm1pZFxuIiBpZiAhZGVmaW5lZCgkdik7Cj4g LSAgICAkdiA9ICR2LT57cWVtdX07Cj4gLQo+IC0gICAgcmV0dXJuIFBWRTo6UWVtdVNlcnZlcjo6 SGVscGVyczo6dmVyc2lvbl9jbXAoJHYtPnttYWpvcn0sICRtYWpvciwgJHYtPnttaW5vcn0sICRt aW5vciwgJHYtPnttaWNyb30sICRleHRyYSkgPj0gMDsKPiAtfQo+IC0KPiAgc3ViIHFlbXVfbWFj aGluZV9weGUgewo+ICAgICAgbXkgKCR2bWlkLCAkY29uZikgPSBAXzsKPiAgCj4gZGlmZiAtLWdp dCBhL1BWRS9RZW11U2VydmVyL1FNUEhlbHBlcnMucG0gYi9QVkUvUWVtdVNlcnZlci9RTVBIZWxw ZXJzLnBtCj4gaW5kZXggZDNhNTIzMjcuLjAyNjllYTQ2IDEwMDY0NAo+IC0tLSBhL1BWRS9RZW11 U2VydmVyL1FNUEhlbHBlcnMucG0KPiArKysgYi9QVkUvUWVtdVNlcnZlci9RTVBIZWxwZXJzLnBt Cj4gQEAgLTMsNiArMyw3IEBAIHBhY2thZ2UgUFZFOjpRZW11U2VydmVyOjpRTVBIZWxwZXJzOwo+ ICB1c2Ugd2FybmluZ3M7Cj4gIHVzZSBzdHJpY3Q7Cj4gIAo+ICt1c2UgUFZFOjpRZW11U2VydmVy OjpIZWxwZXJzOwo+ICB1c2UgUFZFOjpRZW11U2VydmVyOjpNb25pdG9yIHF3KG1vbl9jbWQpOwo+ ICAKPiAgdXNlIGJhc2UgJ0V4cG9ydGVyJzsKPiBAQCAtNDUsNCArNDYsMTYgQEAgc3ViIHFlbXVf b2JqZWN0ZGVsIHsKPiAgICAgIHJldHVybiAxOwo+ICB9Cj4gIAo+ICsjIGRpZXMgaWYgYSkgVk0g bm90IHJ1bm5pbmcgb3Igbm90IGV4aXNpdGluZyBiKSBWZXJzaW9uIHF1ZXJ5IGZhaWxlZAo+ICsj IFNvLCBhbnkgZGVmaW5lZCByZXR1cm4gdmFsdWUgaXMgdmFsaWQsIGFueSBpbnZhbGlkIHN0YXRl IGNhbiBiZSBjYXVnaHQgYnkgZXZhbAo+ICtzdWIgcnVuc19hdF9sZWFzdF9xZW11X3ZlcnNpb24g ewo+ICsgICAgbXkgKCR2bWlkLCAkbWFqb3IsICRtaW5vciwgJGV4dHJhKSA9IEBfOwo+ICsKPiAr ICAgIG15ICR2ID0gUFZFOjpRZW11U2VydmVyOjpNb25pdG9yOjptb25fY21kKCR2bWlkLCAncXVl cnktdmVyc2lvbicpOwo+ICsgICAgZGllICJjb3VsZCBub3QgcXVlcnkgY3VycmVudGx5IHJ1bm5p bmcgdmVyc2lvbiBmb3IgVk0gJHZtaWRcbiIgaWYgIWRlZmluZWQoJHYpOwo+ICsgICAgJHYgPSAk di0+e3FlbXV9Owo+ICsKPiArICAgIHJldHVybiBQVkU6OlFlbXVTZXJ2ZXI6OkhlbHBlcnM6OnZl cnNpb25fY21wKCR2LT57bWFqb3J9LCAkbWFqb3IsICR2LT57bWlub3J9LCAkbWlub3IsICR2LT57 bWljcm99LCAkZXh0cmEpID49IDA7Cj4gK30KPiArCj4gIDE7Cj4gZGlmZiAtLWdpdCBhL3Rlc3Qv TWlncmF0aW9uVGVzdC9RZW11TWlncmF0ZU1vY2sucG0gYi90ZXN0L01pZ3JhdGlvblRlc3QvUWVt dU1pZ3JhdGVNb2NrLnBtCj4gaW5kZXggZjViNDQ0MjQuLjExYzU4YzA4IDEwMDY0NAo+IC0tLSBh L3Rlc3QvTWlncmF0aW9uVGVzdC9RZW11TWlncmF0ZU1vY2sucG0KPiArKysgYi90ZXN0L01pZ3Jh dGlvblRlc3QvUWVtdU1pZ3JhdGVNb2NrLnBtCj4gQEAgLTE4OCw2ICsxODgsMTAgQEAgJHFlbXVf c2VydmVyX21hY2hpbmVfbW9kdWxlLT5tb2NrKAo+ICAJICAgIGlmICFkZWZpbmVkKCR2bV9zdGF0 dXMtPntydW5uaW5nbWFjaGluZX0pOwo+ICAJcmV0dXJuICR2bV9zdGF0dXMtPntydW5uaW5nbWFj aGluZX07Cj4gICAgICB9LAo+ICspOwo+ICsKPiArbXkgJHFlbXVfc2VydmVyX3FtcGhlbHBlcnNf bW9kdWxlID0gVGVzdDo6TW9ja01vZHVsZS0+bmV3KCJQVkU6OlFlbXVTZXJ2ZXI6OlFNUEhlbHBl cnMiKTsKPiArJHFlbXVfc2VydmVyX3FtcGhlbHBlcnNfbW9kdWxlLT5tb2NrKAo+ICAgICAgcnVu c19hdF9sZWFzdF9xZW11X3ZlcnNpb24gPT4gc3ViIHsKPiAgCXJldHVybiAxOwo+ICAgICAgfSwK PiBkaWZmIC0tZ2l0IGEvdGVzdC9ydW5fY29uZmlnMmNvbW1hbmRfdGVzdHMucGwgYi90ZXN0L3J1 bl9jb25maWcyY29tbWFuZF90ZXN0cy5wbAo+IGluZGV4IDcyMTJhY2M0Li5kNDhlZjU2MiAxMDA3 NTUKPiAtLS0gYS90ZXN0L3J1bl9jb25maWcyY29tbWFuZF90ZXN0cy5wbAo+ICsrKyBiL3Rlc3Qv cnVuX2NvbmZpZzJjb21tYW5kX3Rlc3RzLnBsCj4gQEAgLTE2LDcgKzE2LDcgQEAgdXNlIFBWRTo6 U3lzRlNUb29sczsKPiAgdXNlIFBWRTo6UWVtdUNvbmZpZzsKPiAgdXNlIFBWRTo6UWVtdVNlcnZl cjsKPiAgdXNlIFBWRTo6UWVtdVNlcnZlcjo6TW9uaXRvcjsKPiAtdXNlIFBWRTo6UWVtdVNlcnZl cjo6TWFjaGluZTsKPiArdXNlIFBWRTo6UWVtdVNlcnZlcjo6UU1QSGVscGVyczsKPiAgdXNlIFBW RTo6UWVtdVNlcnZlcjo6Q1BVQ29uZmlnOwo+ICAKPiAgbXkgJGJhc2VfZW52ID0gewo+IEBAIC00 NzIsNyArNDcyLDcgQEAgc3ViIGRvX3Rlc3QoJCkgewo+ICAgICAgIyBjaGVjayBpZiBRRU1VIHZl cnNpb24gc2V0IGNvcnJlY3RseSBhbmQgdGVzdCB2ZXJzaW9uX2NtcAo+ICAgICAgKG15ICRxZW11 X21ham9yID0gZ2V0X3Rlc3RfcWVtdV92ZXJzaW9uKCkpID1+IHMvXC4uKiQvLzsKPiAgICAgIGRp ZSAicnVuc19hdF9sZWFzdF9xZW11X3ZlcnNpb24gcmV0dXJuZWQgZmFsc2UsIG1heWJlIGVycm9y IGluIHZlcnNpb25fY21wPyIKPiAtCWlmICFQVkU6OlFlbXVTZXJ2ZXI6Ok1hY2hpbmU6OnJ1bnNf YXRfbGVhc3RfcWVtdV92ZXJzaW9uKCR2bWlkLCAkcWVtdV9tYWpvcik7Cj4gKwlpZiAhUFZFOjpR ZW11U2VydmVyOjpRTVBIZWxwZXJzOjpydW5zX2F0X2xlYXN0X3FlbXVfdmVyc2lvbigkdm1pZCwg JHFlbXVfbWFqb3IpOwo+ICAKPiAgICAgICRjbWRsaW5lID1+IHMvIC0vIFxcXG4gIC0vZzsgIyBz YW1lIGFzIHFtIHNob3djbWQgLS1wcmV0dHkKPiAgICAgICRjbWRsaW5lIC49ICJcbiI7Cj4gLS0g Cj4gMi4zOS4yCj4gCj4gCj4gCj4gX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX18KPiBwdmUtZGV2ZWwgbWFpbGluZyBsaXN0Cj4gcHZlLWRldmVsQGxpc3RzLnBy b3htb3guY29tCj4gaHR0cHM6Ly9saXN0cy5wcm94bW94LmNvbS9jZ2ktYmluL21haWxtYW4vbGlz dGluZm8vcHZlLWRldmVsCj4gCj4gCj4gCgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX18KcHZlLWRldmVsIG1haWxpbmcgbGlzdApwdmUtZGV2ZWxAbGlzdHMu cHJveG1veC5jb20KaHR0cHM6Ly9saXN0cy5wcm94bW94LmNvbS9jZ2ktYmluL21haWxtYW4vbGlz dGluZm8vcHZlLWRldmVsCg==