From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id A33ED1FF38E for ; Tue, 11 Jun 2024 14:08:08 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id EB653364E2; Tue, 11 Jun 2024 14:08:43 +0200 (CEST) Date: Tue, 11 Jun 2024 14:08:37 +0200 From: Fabian =?iso-8859-1?q?Gr=FCnbichler?= To: Proxmox VE development discussion References: <20240503111956.46543-1-f.ebner@proxmox.com> In-Reply-To: <20240503111956.46543-1-f.ebner@proxmox.com> MIME-Version: 1.0 User-Agent: astroid/0.16.0 (https://github.com/astroidmail/astroid) Message-Id: <1718107708.a18064iq09.astroid@yuna.none> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.057 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [qemu.pm, monitor.pm, proxmox.com, qm.pm, qemuserver.pm] Subject: [pve-devel] applied-series: [PATCH-SERIES qemu-server/manager] fix #5440: HMP/disk timeout improvements X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" thanks! On May 3, 2024 1:19 pm, Fiona Ebner wrote: > Currently, all HMP commands (issued as a "human-monitor-command" QMP > command) use the default timeout for QMP commands of just 5 seconds. > > For drive-related commands, this is not always enough, as reported in > bug #5440. Other drive-related QMP commands use 10 minutes, so it is > natural to increase the limit for the HMP command for detaching a > drive to that too. > > Other HMP commands that are issued are limited by being in a > synchronous API call or interactive monitor session, but can still > benefit from an increased timeout over the 5 second default. > > Lastly, the UI is adapted to use the asynchronous API call when > hot-unplugging a drive, to be more in-line with the backend. > > > qemu-server: > > Fiona Ebner (5): > monitor: allow passing timeout for a HMP command > api: human monitor: increase timeout to 25 seconds > vzdump: increase timeout for attaching drives to 60 seconds > cli: qm: increase timeout for monitor commands to 30 seconds > fix #5440: hmp helpers: drive{add,del}: increase timeout > > PVE/API2/Qemu.pm | 2 +- > PVE/CLI/qm.pm | 2 +- > PVE/QemuServer.pm | 4 ++-- > PVE/QemuServer/Monitor.pm | 4 ++-- > PVE/VZDump/QemuServer.pm | 4 ++-- > 5 files changed, 8 insertions(+), 8 deletions(-) > > > pve-manager: > > Fiona Ebner (2): > ui: qemu: hardware: use background delay for asynchronous remove tasks > ui: qemu: hardware: use asynchronous remove API call for disk > hot-unplug > > www/manager6/qemu/HardwareView.js | 15 +++++++++------ > 1 file changed, 9 insertions(+), 6 deletions(-) > > -- > 2.39.2 > > > > _______________________________________________ > pve-devel mailing list > pve-devel@lists.proxmox.com > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel > > > _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel