From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 5AA7A1FF396 for ; Wed, 22 May 2024 10:55:58 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id D89D88753; Wed, 22 May 2024 10:56:14 +0200 (CEST) Date: Wed, 22 May 2024 10:56:08 +0200 From: Fabian =?iso-8859-1?q?Gr=FCnbichler?= To: Proxmox VE development discussion References: <20240429112124.3819357-1-d.csapak@proxmox.com> <20240429112124.3819357-2-d.csapak@proxmox.com> In-Reply-To: <20240429112124.3819357-2-d.csapak@proxmox.com> MIME-Version: 1.0 User-Agent: astroid/0.16.0 (https://github.com/astroidmail/astroid) Message-Id: <1716367674.5uo4euowli.astroid@yuna.none> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.054 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [dmtf.org, ovf.pm] Subject: Re: [pve-devel] [PATCH storage v3 01/10] copy OVF.pm from qemu-server X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" On April 29, 2024 1:21 pm, Dominik Csapak wrote: > copies the OVF.pm and relevant ovf tests from qemu-server. > We need it here, and it uses PVE::Storage already, and since there is no > intermediary package/repository we could put it, it seems fitting in > here. > > Put it in a new GuestImport module > > Signed-off-by: Dominik Csapak > --- > src/PVE/GuestImport/Makefile | 3 + > src/PVE/GuestImport/OVF.pm | 242 ++++++++++++++++++ > src/PVE/Makefile | 1 + > src/PVE/Storage/Makefile | 1 + > src/test/Makefile | 5 +- > src/test/ovf_manifests/Win10-Liz-disk1.vmdk | Bin 0 -> 65536 bytes > src/test/ovf_manifests/Win10-Liz.ovf | 142 ++++++++++ > .../ovf_manifests/Win10-Liz_no_default_ns.ovf | 142 ++++++++++ > .../ovf_manifests/Win_2008_R2_two-disks.ovf | 145 +++++++++++ > src/test/ovf_manifests/disk1.vmdk | Bin 0 -> 65536 bytes > src/test/ovf_manifests/disk2.vmdk | Bin 0 -> 65536 bytes > src/test/run_ovf_tests.pl | 71 +++++ > 12 files changed, 751 insertions(+), 1 deletion(-) > create mode 100644 src/PVE/GuestImport/Makefile > create mode 100644 src/PVE/GuestImport/OVF.pm > create mode 100644 src/test/ovf_manifests/Win10-Liz-disk1.vmdk > create mode 100755 src/test/ovf_manifests/Win10-Liz.ovf > create mode 100755 src/test/ovf_manifests/Win10-Liz_no_default_ns.ovf > create mode 100755 src/test/ovf_manifests/Win_2008_R2_two-disks.ovf > create mode 100644 src/test/ovf_manifests/disk1.vmdk > create mode 100644 src/test/ovf_manifests/disk2.vmdk > create mode 100755 src/test/run_ovf_tests.pl > > diff --git a/src/PVE/GuestImport/Makefile b/src/PVE/GuestImport/Makefile > new file mode 100644 > index 0000000..5948384 > --- /dev/null > +++ b/src/PVE/GuestImport/Makefile > @@ -0,0 +1,3 @@ > +.PHONY: install > +install: > + install -D -m 0644 OVF.pm ${DESTDIR}${PERLDIR}/PVE/GuestImport/OVF.pm > diff --git a/src/PVE/GuestImport/OVF.pm b/src/PVE/GuestImport/OVF.pm > new file mode 100644 > index 0000000..055ebf5 > --- /dev/null > +++ b/src/PVE/GuestImport/OVF.pm > @@ -0,0 +1,242 @@ > +# Open Virtualization Format import routines > +# https://www.dmtf.org/standards/ovf > +package PVE::GuestImport::OVF; > + > +use strict; > +use warnings; > + > +use XML::LibXML; this means the libxml-libxml-perl dependency should also move from qemu-server to libpve-storage-perl > +use File::Spec; > +use File::Basename; > +use Data::Dumper; not used? > +use Cwd 'realpath'; > + > +use PVE::Tools; > +use PVE::Storage; this one here makes a circular dependency, since the DirPlugin then uses this module.. it is within the repository though, which we have quite often, but it's a bit of a bummer.. > + > [..] _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel