From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <pve-devel-bounces@lists.proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id CAFC71FF380 for <inbox@lore.proxmox.com>; Fri, 19 Apr 2024 13:23:11 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 4BEE972C6; Fri, 19 Apr 2024 13:23:12 +0200 (CEST) Date: Fri, 19 Apr 2024 13:22:36 +0200 From: Fabian =?iso-8859-1?q?Gr=FCnbichler?= <f.gruenbichler@proxmox.com> To: Fiona Ebner <f.ebner@proxmox.com>, Lukas Wagner <l.wagner@proxmox.com>, Proxmox VE development discussion <pve-devel@lists.proxmox.com> References: <20240409132555.364926-1-l.wagner@proxmox.com> <f74303dc-19eb-44c9-a920-066d4bf4f5ab@proxmox.com> In-Reply-To: <f74303dc-19eb-44c9-a920-066d4bf4f5ab@proxmox.com> MIME-Version: 1.0 User-Agent: astroid/0.16.0 (https://github.com/astroidmail/astroid) Message-Id: <1713525399.cfon6yc51e.astroid@yuna.none> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.055 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH many 00/19] notifications: move template strings to template files; PBS preparations X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com> Cc: Thomas Lamprecht <t.lamprecht@proxmox.com> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com> On April 19, 2024 12:09 pm, Fiona Ebner wrote: > Am 09.04.24 um 15:25 schrieb Lukas Wagner: >> Bumps/dependencies: >> - proxmox_notify >> - libproxmox-rs-perl/libpve-rs-perl (needs bumped proxmox_notify) >> - libpve-notify-perl (needs bumped libproxmox-rs-perl/libpve-rs-perl) >> - pve-ha-manager (needs bumped libpve-notify-perl) >> - pve-manager (needs bumped libpve-notify-perl) >> - proxmox-mail-forward (optional. should not be affected by any changes, but I think >> it should be also be bumped for any larger proxmox_notify changes to avoid any >> weird hidden regressions due to mismatches of proxmox_notify >> > > Versioned breaks required: > - new pve-cluster will break old pve-manager and old pve-ha-manager > - new libproxmox-rs-perl/libpve-rs-perl will break old pve-cluster > > Still not too sure about putting the templates in > /usr/share/proxmox-ve/, but maybe @Thomas or @Fabian can chime in on that. without in-depth look at all the changes in this series, I think it would make most sense for the package shipping (most?) templates to "own" the dir where they are shipped. that seems to be pve-manager, so maybe /usr/share/pve-manager would be an okay fit? or, if we want to avoid having "pve-manager" there, we could of course also create /usr/share/pve or /usr/lib/pve or one of those with "proxmox" instead of "pve", and have that owned by pve-manager.. I dislike proxmox-ve - it might not be the case that it is always installed, which means potential pitfalls for such non-standard systems or if we ever make it optional like we did for PMG/PBS (granted, not very likely, but still..) - normally the /usr/share/$package dir should only be used by $package _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel