From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <f.gruenbichler@proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id A1E1191DD2 for <pve-devel@lists.proxmox.com>; Wed, 31 Jan 2024 14:19:29 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 8369E3AD65 for <pve-devel@lists.proxmox.com>; Wed, 31 Jan 2024 14:18:59 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for <pve-devel@lists.proxmox.com>; Wed, 31 Jan 2024 14:18:58 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 940814936B for <pve-devel@lists.proxmox.com>; Wed, 31 Jan 2024 14:18:58 +0100 (CET) Date: Wed, 31 Jan 2024 14:18:52 +0100 From: Fabian =?iso-8859-1?q?Gr=FCnbichler?= <f.gruenbichler@proxmox.com> To: Proxmox VE development discussion <pve-devel@lists.proxmox.com> References: <20240130184041.1125674-1-m.carrara@proxmox.com> <20240130184041.1125674-2-m.carrara@proxmox.com> In-Reply-To: <20240130184041.1125674-2-m.carrara@proxmox.com> MIME-Version: 1.0 User-Agent: astroid/0.16.0 (https://github.com/astroidmail/astroid) Message-Id: <1706701255.osw2c9wm3p.astroid@yuna.none> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-SPAM-LEVEL: Spam detection results: 0 AWL 0.065 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pve-devel] [PATCH master ceph 1/8] debian: add patch to fix ceph crash dir permissions in postinst hook X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> X-List-Received-Date: Wed, 31 Jan 2024 13:19:29 -0000 On January 30, 2024 7:40 pm, Max Carrara wrote: > Ceph has a postinst hook that sets the ownership of '/var/lib/ceph/*' > to ceph:ceph (in our case), but misses out on '/var/lib/ceph/crash/posted= '. >=20 > This patch therefore also updates the permissions of '/var/lib/ceph/*/*'. >=20 > Signed-off-by: Max Carrara <m.carrara@proxmox.com> > --- > ...rmissions-of-subdirectories-of-var-l.patch | 42 +++++++++++++++++++ > patches/series | 1 + > 2 files changed, 43 insertions(+) > create mode 100644 patches/0015-debian-adjust-permissions-of-subdirector= ies-of-var-l.patch >=20 > diff --git a/patches/0015-debian-adjust-permissions-of-subdirectories-of-= var-l.patch b/patches/0015-debian-adjust-permissions-of-subdirectories-of-v= ar-l.patch > new file mode 100644 > index 000000000..951a2a6ed > --- /dev/null > +++ b/patches/0015-debian-adjust-permissions-of-subdirectories-of-var-l.p= atch > @@ -0,0 +1,42 @@ > +From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001 > +From: Max Carrara <m.carrara@proxmox.com> > +Date: Thu, 11 Jan 2024 14:04:16 +0100 > +Subject: [PATCH] debian: adjust permissions of subdirectories of /var/li= b/ceph > + > +A rather recent PR made ceph-crash run as "ceph" user instead of > +root [0]. However, because /var/lib/ceph/crash/posted belongs to root, > +ceph-crash cannot actually post any crash logs now. > + > +This commit fixes this by also updating the permissions of > +/var/lib/ceph/*/* - the subdirectories of the directories in > +/var/lib/ceph. > + > +[0]: https://github.com/ceph/ceph/pull/48713 > + > +Signed-off-by: Max Carrara <m.carrara@proxmox.com> > +--- > + debian/ceph-base.postinst | 8 ++++++++ > + 1 file changed, 8 insertions(+) > + > +diff --git a/debian/ceph-base.postinst b/debian/ceph-base.postinst > +index 75eeb59c624..7ca0b9b6c43 100644 > +--- a/debian/ceph-base.postinst > ++++ b/debian/ceph-base.postinst > +@@ -40,6 +40,14 @@ case "$1" in > + chown $SERVER_USER:$SERVER_GROUP $DIR > + fi > + done > ++ > ++ # also adjust file and directory permissons for subdirectories > ++ for SUBDIR in /var/lib/ceph/*/* ; do > ++ if ! dpkg-statoverride --list $SUBDIR >/dev/null > ++ then > ++ chown $SERVER_USER:$SERVER_GROUP $SUBDIR > ++ fi this would probably benefit from being merged with the loop above and being switched to find? find(utils) is Essential, so its existence is a given.. did you forward this patch upstream? if not, please do so :)