Re: [PATCH qemu-server 2/6] tests: hotplug: add some test cases

[Fiona Ebner <f.ebner@proxmox.com>]

Am 11.09.26 um 12:11 PM schrieb Dominik Csapak:
> On 9/10/26 4:24 PM, Fiona Ebner wrote:
>> Am 10.09.26 um 1:29 PM schrieb Dominik Csapak:
>>> +
>>> +# resulting config
>>> +arch: aarch64
>>> +bios: ovmf
>>> +bootdisk: scsi0
>>> +cores: 2
>>> +efidisk0: local:8006/vm-8006-disk-2.qcow2,efitype=4m
>>> +memory: 2048
>>> +name: hotplug
>>> +net0: virtio=A2:C0:43:77:08:A0,bridge=vmbr0
>>> +ostype: l26
>>> +scsi0: local:8006/vm-8006-disk-0.qcow2,size=32G
>>> +scsihw: virtio-scsi-pci
>>> +smbios1: uuid=7b10d7af-b932-4c66-b2c3-3996152ec465
>>> +sockets: 1
>>> +virtio1: local:8006/vm-8006-disk-1.qcow2,iothread=1,size=32G
>>> +vmgenid: c773c261-d800-4348-9f5d-167fadd53cf8
>>
>> Would just recording and the changes be more sensible to avoid lots of
>> redundant information? That could also already live in the test
>> definition with the test runner checking that nothing additional is
>> changed. In most cases it will directly overlap with what is in
>> [PENDING], so you don't even need to specify any additional expected
>> changes.
>>
>> What do you think?
> 
> what about not recording the resulting config at all as an expected
> file, but simply check in the test if there is still a
> [PENDING] section, mark tests where this is expected and
> fail where this is not the case?
> 
> then we could have a simple file with the recorded qmp/hmp calls
> in a list without any comment structure

Yeah, sounds good too :)