From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <f.gruenbichler@proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 4806DE8C1 for <pve-devel@lists.proxmox.com>; Wed, 19 Jul 2023 14:09:39 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 2FD2B6A3E for <pve-devel@lists.proxmox.com>; Wed, 19 Jul 2023 14:09:09 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for <pve-devel@lists.proxmox.com>; Wed, 19 Jul 2023 14:09:05 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 7EA0D41023 for <pve-devel@lists.proxmox.com>; Wed, 19 Jul 2023 14:09:05 +0200 (CEST) Date: Wed, 19 Jul 2023 14:08:53 +0200 From: Fabian =?iso-8859-1?q?Gr=FCnbichler?= <f.gruenbichler@proxmox.com> To: Proxmox VE development discussion <pve-devel@lists.proxmox.com> References: <20230706105421.54949-1-m.frank@proxmox.com> In-Reply-To: <20230706105421.54949-1-m.frank@proxmox.com> MIME-Version: 1.0 User-Agent: astroid/0.16.0 (https://github.com/astroidmail/astroid) Message-Id: <1689766934.x81323ghkt.astroid@yuna.none> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-SPAM-LEVEL: Spam detection results: 0 AWL 0.070 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pve-devel] [PATCH cluster/guest-common/qemu-server/manager v6 0/11] virtiofs X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> X-List-Received-Date: Wed, 19 Jul 2023 12:09:39 -0000 high level: - some indication for which patches require which patches and/or package relation bumps would be nice (e.g., qemu-server -> pve-guest-common and pve-manager -> pve-doc-generator) - the qemu-server unit tests fail for me with the patches, but work without. they do work when run as root, so I assume some mocking for pmxcfs related things is missing if I start a VM with `qm start`: Jul 19 13:57:48 yuna qm[3872900]: <root@pam> starting task UPID:yuna:003B18= 97:0127A0F1:64B7CFBC:qmstart:901:root@pam: Jul 19 13:57:48 yuna qm[3872919]: start VM 901: UPID:yuna:003B1897:0127A0F1= :64B7CFBC:qmstart:901:root@pam: Jul 19 13:57:48 yuna systemd[1]: Started 901.scope. Jul 19 13:57:48 yuna kernel: device tap901i0 entered promiscuous mode Jul 19 13:57:48 yuna kernel: vmbr10: port 2(tap901i0) entered blocking stat= e Jul 19 13:57:48 yuna kernel: vmbr10: port 2(tap901i0) entered disabled stat= e Jul 19 13:57:48 yuna kernel: vmbr10: port 2(tap901i0) entered blocking stat= e Jul 19 13:57:48 yuna kernel: vmbr10: port 2(tap901i0) entered listening sta= te Jul 19 13:57:48 yuna QEMU[3872940]: kvm: Unexpected end-of-file before all = data were read Jul 19 13:57:48 yuna qm[3872923]: command '/usr/libexec/virtiofsd '--fd=3D9= ' '--shared-dir=3D/var/lib/apt'' failed: received interrupt Jul 19 13:57:48 yuna qm[3872900]: <root@pam> end task UPID:yuna:003B1897:01= 27A0F1:64B7CFBC:qmstart:901:root@pam: OK Jul 19 13:57:48 yuna sudo[3872855]: pam_unix(sudo:session): session closed = for user root Jul 19 13:57:59 yuna QEMU[3872940]: kvm: Failed to set msg fds. Jul 19 13:57:59 yuna QEMU[3872940]: kvm: vhost_set_vring_call failed 22 Jul 19 13:57:59 yuna QEMU[3872940]: kvm: Failed to set msg fds. Jul 19 13:57:59 yuna QEMU[3872940]: kvm: vhost_set_vring_call failed 22 Jul 19 13:57:59 yuna QEMU[3872940]: kvm: Failed to set msg fds. Jul 19 13:57:59 yuna QEMU[3872940]: kvm: vhost_set_features failed: Invalid= argument (22) Jul 19 13:57:59 yuna QEMU[3872940]: kvm: Error starting vhost: 22 Jul 19 13:57:59 yuna QEMU[3872940]: kvm: Failed to set msg fds. Jul 19 13:57:59 yuna QEMU[3872940]: kvm: vhost_set_vring_call failed 22 Jul 19 13:57:59 yuna QEMU[3872940]: kvm: Failed to set msg fds. Jul 19 13:57:59 yuna QEMU[3872940]: kvm: vhost_set_vring_call failed 22 $ qm start 901 [2023-07-19T11:57:48Z INFO virtiofsd] Waiting for vhost-user socket connec= tion... [2023-07-19T11:57:48Z INFO virtiofsd] Client connected, servicing requests with only the qemu process in the systemd scope for that VM.. if I start via the API, the above issue goes away, but as noted by Friedrich, the virtiofsd process is not part of the VM scope, but a child of the start task, and lingers after the VM has been stopped. On July 6, 2023 12:54 pm, Markus Frank wrote: > cluster: >=20 > Markus Frank (1): > add mapping/dir.cfg for resource mapping >=20 > src/PVE/Cluster.pm | 1 + > src/pmxcfs/status.c | 1 + > 2 files changed, 2 insertions(+) >=20 >=20 > guest-common: >=20 > Markus Frank (1): > add DIR mapping config >=20 > src/Makefile | 1 + > src/PVE/Mapping/DIR.pm | 175 +++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 176 insertions(+) > create mode 100644 src/PVE/Mapping/DIR.pm >=20 >=20 > qemu-server: >=20 > v6: > * added virtiofsd dependency > * 2 new patches: > * Permission check for virtiofs directory access > * check_local_resources: virtiofs >=20 > v5: > * allow numa settings with virtio-fs > * added direct-io & cache settings > * changed to rust implementation of virtiofsd > * made double fork and closed all file descriptor so that the lockfile > gets released. >=20 > v3: > * created own socket and get file descriptor for virtiofsd > so there is no race between starting virtiofsd & qemu > * added TODO to replace virtiofsd with rust implementation in bookworm > (I packaged the rust implementation for bookworm & the C implementation > in qemu will be removed in qemu 8.0) >=20 > v2: > * replaced sharedfiles_fmt path in qemu-server with dirid: > * user can use the dirid to specify the directory without requiring root= access >=20 > Markus Frank (3): > feature #1027: virtio-fs support > Permission check for virtiofs directory access > check_local_resources: virtiofs >=20 > PVE/API2/Qemu.pm | 18 +++++ > PVE/QemuServer.pm | 167 ++++++++++++++++++++++++++++++++++++++- > PVE/QemuServer/Memory.pm | 25 ++++-- > debian/control | 1 + > 4 files changed, 204 insertions(+), 7 deletions(-) >=20 >=20 > manager: >=20 > v6: completly new except "ui: added options to add virtio-fs to qemu conf= ig" >=20 > Markus Frank (5): > api: add resource map api endpoints for directories > ui: add edit window for dir mappings > ui: ResourceMapTree for DIR > ui: form: add DIRMapSelector > ui: added options to add virtio-fs to qemu config >=20 > PVE/API2/Cluster/Mapping.pm | 7 + > PVE/API2/Cluster/Mapping/DIR.pm | 299 ++++++++++++++++++++++++++++ > PVE/API2/Cluster/Mapping/Makefile | 3 +- > www/manager6/Makefile | 4 + > www/manager6/Utils.js | 1 + > www/manager6/dc/Config.js | 10 + > www/manager6/dc/DIRMapView.js | 50 +++++ > www/manager6/form/DIRMapSelector.js | 63 ++++++ > www/manager6/qemu/HardwareView.js | 19 ++ > www/manager6/qemu/VirtiofsEdit.js | 120 +++++++++++ > www/manager6/window/DIRMapEdit.js | 186 +++++++++++++++++ > 11 files changed, 761 insertions(+), 1 deletion(-) > create mode 100644 PVE/API2/Cluster/Mapping/DIR.pm > create mode 100644 www/manager6/dc/DIRMapView.js > create mode 100644 www/manager6/form/DIRMapSelector.js > create mode 100644 www/manager6/qemu/VirtiofsEdit.js > create mode 100644 www/manager6/window/DIRMapEdit.js >=20 > --=20 > 2.39.2 >=20 >=20 >=20 > _______________________________________________ > pve-devel mailing list > pve-devel@lists.proxmox.com > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel >=20 >=20 >=20