all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: 結友 <miagetegorann@gmail.com>, pve-devel@lists.proxmox.com
Subject: Re: [PATCH pve-kernel v4 2/2] fix #8027: config: enable CONFIG_HYPERV_VMBUS
Date: Tue, 17 Nov 2026 00:54:00 +0100	[thread overview]
Message-ID: <167b37d9-79d3-49d2-8ac0-28785ac1a275@proxmox.com> (raw)
In-Reply-To: <20261024052438.1274-3-miagetegorann@gmail.com>

Thanks for the patch, change is ok, commit itself not so much IMO

Am 24.10.26 um 07:25 schrieb 結友:
> Linux 6.18 split the Hyper-V guest support options: CONFIG_HYPERV became a
> plain bool covering only the core hypervisor support, and the VMBus bus
> driver moved to the new tristate CONFIG_HYPERV_VMBUS:
> 
>   -obj-$(CONFIG_HYPERV)       += hv_vmbus.o
>   +obj-$(CONFIG_HYPERV_VMBUS) += hv_vmbus.o
> 
> (upstream 94b04355e639 ("Drivers: hv: Add CONFIG_HYPERV_VMBUS option") and
> e3ec97c3abaf ("Drivers: hv: Make CONFIG_HYPERV bool"))
> 
> So the `-e CONFIG_HYPERV` added in ef257cb ("config: enable CONFIG_HYPERV")
> does not build the VMBus driver into the kernel anymore. CONFIG_HYPERV_VMBUS
> does default to HYPERV, but the Ubuntu config sets it to 'm' explicitly and
> olddefconfig keeps that. proxmox-kernel-6.17.13-21-pve accordingly still
> lists kernel/drivers/hv/hv_vmbus.ko in modules.builtin, while 7.0.2-6-pve
> and 7.0.14-25-pve ship it as a module.
> 
> That breaks installing Proxmox VE in a Hyper-V Generation 2 VM, where the
> storage controller is a VMBus device: VMBus devices only appear in sysfs
> once hv_vmbus has been probed. The installer initrd collects the list of
> /sys/devices/**/modalias once, before loading the modules discovered
> through those aliases. It loads hv_vmbus through the ACPI VMBus node,
> but never sees the vmbus: aliases of its children. hv_storvsc therefore
> stays unloaded, no /dev/sr0 shows up and the installation aborts with
> "no device with valid ISO found". Accordingly the 9.2 ISO fails, while
> the 9.1 one with its 6.17 kernel works.
> 
> With hv_vmbus built in again, the VMBus children are already enumerated by
> the time the initrd runs, so that single modalias scan picks up hv_storvsc
> on its own.
> 
> Record in the README why it has to be built in rather than modular.

This is a *lot* of text that doesn't provides much extra value and
repeats the same thing over and over. For such a simple patch it's not
really needed to have all this verbosity, on the contrary – it makes
reviewers rather skip this as its clearly generated (not a problem
per se) without re-reading and trimming down to a nice submission (not
ideal).

Commit message could be just:

----8<----
Linux 6.18 split out the Hyper-V VMBus to its own HYPERV_VMBUS KConfig
flag. This broke using any Proxmox project with this kernel in a
Hyper-V Gen 2 VM, which attaches disks through a VMBus controller. 

Explicitly enable CONFIG_HYPERV_VMBUS to restore support.
---->8----

May be not perfect, but concise and to the point and quick to read
with all relevant bits included.

I now applied such a minimal commit with you credited via link
and Originally-by trailers:

https://git.proxmox.com/?p=pve-kernel.git;a=commitdiff;h=623dd7760583bdadb84540ec077e128e39f3eb98




  reply	other threads:[~2026-11-16 23:54 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-24  5:24 [PATCH pve-kernel v4 0/2] fix #8027: restore built-in Hyper-V VMBus 結友
2026-10-24  5:24 ` [PATCH pve-kernel v4 1/2] d/scripts: correctly compare namespaced ABI exports 結友
2026-11-16 21:48   ` Thomas Lamprecht
2026-11-16 23:50     ` 結友
2026-10-24  5:24 ` [PATCH pve-kernel v4 2/2] fix #8027: config: enable CONFIG_HYPERV_VMBUS 結友
2026-11-16 23:54   ` Thomas Lamprecht [this message]
2026-11-17  0:03     ` 結友
2026-11-09 18:39 ` [PATCH pve-kernel v4 0/2] fix #8027: restore built-in Hyper-V VMBus 山﨑結友

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=167b37d9-79d3-49d2-8ac0-28785ac1a275@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=miagetegorann@gmail.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal