From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <f.gruenbichler@proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits))
(No client certificate requested)
by lists.proxmox.com (Postfix) with ESMTPS id 2C626B2DF
for <pve-devel@lists.proxmox.com>; Wed, 6 Apr 2022 14:10:37 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id 1B4342AD43
for <pve-devel@lists.proxmox.com>; Wed, 6 Apr 2022 14:10:37 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com
[94.136.29.106])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits))
(No client certificate requested)
by firstgate.proxmox.com (Proxmox) with ESMTPS id 1CD6B2AD3A
for <pve-devel@lists.proxmox.com>; Wed, 6 Apr 2022 14:10:36 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])
by proxmox-new.maurer-it.com (Proxmox) with ESMTP id E0BB041FCF
for <pve-devel@lists.proxmox.com>; Wed, 6 Apr 2022 14:10:35 +0200 (CEST)
Date: Wed, 06 Apr 2022 14:10:16 +0200
From: Fabian =?iso-8859-1?q?Gr=FCnbichler?= <f.gruenbichler@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
References: <20220329125324.120737-1-f.ebner@proxmox.com>
In-Reply-To: <20220329125324.120737-1-f.ebner@proxmox.com>
MIME-Version: 1.0
User-Agent: astroid/0.15.0 (https://github.com/astroidmail/astroid)
Message-Id: <1649246943.cvi1zlor86.astroid@nora.none>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-SPAM-LEVEL: Spam detection results: 0
AWL -0.074 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
T_SCC_BODY_TEXT_LINE -0.01 -
URI_NOVOWEL 0.5 URI hostname has long non-vowel sequence
Subject: [pve-devel] partially-applied: [PATCH-SERIES v2
storage/manager/guest-common/docs] improvements for protected backups
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
X-List-Received-Date: Wed, 06 Apr 2022 12:10:37 -0000
pve-storage (+bump)
first part of series regarding counting protected + small follow-up=20
discussed off-list
second part with note templates requires a re-send for {{VAR}} syntax.
On March 29, 2022 2:53 pm, Fabian Ebner wrote:
> The series consists of two parts:
>=20
> First part (up to docs 2/2) is for introducing a storage property
> to limit the number of protected backups and only count unprotected
> backups for the limit check in vzdump. This is useful to still be able
> to limit the amount of backups a user can make, because protected
> backups are not considered when pruning, and a user with backup
> privilege could mark their new backups as protected each time.
>=20
> Second part introduces 'protected' and a 'notes-template' option to
> generate notes from a template string with certain variables for
> vzdump, and adds them for manual backup and backup jobs in the UI.
>=20
>=20
> Changes from v1:
> * Add some rationale to the cover letter.
> * Drop already applied patch.
> * Default to unlimited for privileged users. I also dropped the
> patch to dynamically set the property upon storage creation in
> the UI, because the default itself is more dynamic now.
> * Switch to a template string for notes, supporting certain
> variables.
>=20
>=20
> Previous discussion here:
> https://lists.proxmox.com/pipermail/pve-devel/2021-December/051214.html
>=20
>=20
> storage:
>=20
> Fabian Ebner (1):
> plugins: allow limiting the number of protected backups per guest
>=20
> PVE/Storage.pm | 35 ++++++++++++++++++++++++++++++++++
> PVE/Storage/BTRFSPlugin.pm | 3 ++-
> PVE/Storage/CIFSPlugin.pm | 1 +
> PVE/Storage/CephFSPlugin.pm | 1 +
> PVE/Storage/DirPlugin.pm | 1 +
> PVE/Storage/GlusterfsPlugin.pm | 1 +
> PVE/Storage/NFSPlugin.pm | 1 +
> PVE/Storage/PBSPlugin.pm | 1 +
> PVE/Storage/Plugin.pm | 7 +++++++
> 9 files changed, 50 insertions(+), 1 deletion(-)
>=20
>=20
> manager:
>=20
> Fabian Ebner (8):
> vzdump: backup file list: drop unused parameter
> vzdump: backup limit: only count unprotected backups
> ui: storage edit: retention: add max-protected-backups setting
> vzdump: support setting protected status
> partially close #438: vzdump: support setting notes-template
> ui: backup: allow setting protected and notes-template for manual
> backup
> close #438: ui: backup job: allow setting a notes-template for a job
> ui: backup job: set guest name as default notes-template
>=20
> PVE/VZDump.pm | 89 +++++++++++++++++++++-------
> www/manager6/dc/Backup.js | 18 ++++++
> www/manager6/panel/BackupJobPrune.js | 47 ++++++++++++---
> www/manager6/storage/Base.js | 1 +
> www/manager6/window/Backup.js | 25 +++++++-
> 5 files changed, 147 insertions(+), 33 deletions(-)
>=20
>=20
> docs:
>=20
> Fabian Ebner (2):
> storage: switch to prune-backups in examples
> vzdump/storage: mention protected backups limit and give an example
>=20
> pve-storage-dir.adoc | 9 +++++----
> pve-storage-pbs.adoc | 2 +-
> vzdump.adoc | 5 +++++
> 3 files changed, 11 insertions(+), 5 deletions(-)
>=20
>=20
> guest-common:
>=20
> Fabian Ebner (1):
> vzdump: schema: add 'notes-template' and 'protected' properties
>=20
> src/PVE/VZDump/Common.pm | 16 +++++++++++++++-
> 1 file changed, 15 insertions(+), 1 deletion(-)
>=20
> --=20
> 2.30.2
>=20
>=20
>=20
> _______________________________________________
> pve-devel mailing list
> pve-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
>=20
>=20
>=20