From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pbs-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
	by lore.proxmox.com (Postfix) with ESMTPS id 1480D1FF56B
	for <inbox@lore.proxmox.com>; Mon, 22 Apr 2024 11:48:50 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
	by firstgate.proxmox.com (Proxmox) with ESMTP id 8CAE2DBE8;
	Mon, 22 Apr 2024 11:48:53 +0200 (CEST)
Date: Mon, 22 Apr 2024 11:48:20 +0200 (CEST)
From: Dietmar Maurer <dietmar@proxmox.com>
To: Proxmox Backup Server development discussion <pbs-devel@lists.proxmox.com>, 
 Thomas Lamprecht <t.lamprecht@proxmox.com>,
 Hannes Laimer <h.laimer@proxmox.com>
Message-ID: <1629204269.9163.1713779300855@webmail.proxmox.com>
In-Reply-To: <770421677.9141.1713778171599@webmail.proxmox.com>
References: <20240419155606.112010-1-h.laimer@proxmox.com>
 <20240419155606.112010-3-h.laimer@proxmox.com>
 <310fe4e2-b917-4771-b1ea-1c7f1bcb6128@proxmox.com>
 <770421677.9141.1713778171599@webmail.proxmox.com>
MIME-Version: 1.0
X-Priority: 3
Importance: Normal
X-Mailer: Open-Xchange Mailer v7.10.6-Rev61
X-Originating-Client: open-xchange-appsuite
X-SPAM-LEVEL: Spam detection results:  0
 AWL 0.350 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 DMARC_MISSING             0.1 Missing DMARC policy
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_PASS               -0.001 SPF: sender matches SPF record
Subject: Re: [pbs-devel] [PATCH proxmox-backup v8 02/23] pbs-api-types: add
 backing-device to DataStoreConfig
X-BeenThere: pbs-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox Backup Server development discussion
 <pbs-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pbs-devel>, 
 <mailto:pbs-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pbs-devel/>
List-Post: <mailto:pbs-devel@lists.proxmox.com>
List-Help: <mailto:pbs-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel>, 
 <mailto:pbs-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Proxmox Backup Server development discussion
 <pbs-devel@lists.proxmox.com>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: pbs-devel-bounces@lists.proxmox.com
Sender: "pbs-devel" <pbs-devel-bounces@lists.proxmox.com>


> On 22.4.2024 11:29 CEST Dietmar Maurer <dietmar@proxmox.com> wrote:
> 
>  
> > > +pub const REMOVABLE_DATASTORE_MOUNT_DIR: &str = "/mnt/removable_datastore";
> > 
> > please use kebab-case: removable-datastore 
> > 
> > It would be great to write some reasoning for using a different mount
> > path for removable datastore, as IMO that's really not something
> > obvious..
> > 
> > In fact, why do we require having that separate?
> 
> I can imagine problems if the user tries to add the same removable datastore multiple times with different names, or if something fails during add datastore.
> 
> not sure about this...


Another problem arise if we allow multiple datastores on a single disk.

Using a fixed REMOVABLE_DATASTORE_MOUNT_DIR solves those problems.


_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel