From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <f.gruenbichler@proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits))
(No client certificate requested)
by lists.proxmox.com (Postfix) with ESMTPS id BA38375B4E
for <pve-devel@lists.proxmox.com>; Thu, 22 Apr 2021 16:01:12 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id AE86A1CB92
for <pve-devel@lists.proxmox.com>; Thu, 22 Apr 2021 16:01:12 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com
[94.136.29.106])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits))
(No client certificate requested)
by firstgate.proxmox.com (Proxmox) with ESMTPS id D48E11CB87
for <pve-devel@lists.proxmox.com>; Thu, 22 Apr 2021 16:01:11 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])
by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 929C14626B
for <pve-devel@lists.proxmox.com>; Thu, 22 Apr 2021 16:01:11 +0200 (CEST)
Date: Thu, 22 Apr 2021 16:01:03 +0200
From: Fabian =?iso-8859-1?q?Gr=FCnbichler?= <f.gruenbichler@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
References: <20210422111801.4193-1-s.ivanov@proxmox.com>
<20210422111801.4193-3-s.ivanov@proxmox.com>
In-Reply-To: <20210422111801.4193-3-s.ivanov@proxmox.com>
MIME-Version: 1.0
User-Agent: astroid/0.15.0 (https://github.com/astroidmail/astroid)
Message-Id: <1619099984.o68gb1m8s2.astroid@nora.none>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-SPAM-LEVEL: Spam detection results: 0
AWL 0.050 Adjusted score from AWL reputation of From: address
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See
http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more
information. [proxmox.com]
Subject: Re: [pve-devel] [PATCH pve-kernel-meta 2/7] proxmox-boot-tool: add
status command
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
X-List-Received-Date: Thu, 22 Apr 2021 14:01:12 -0000
On April 22, 2021 1:17 pm, Stoiko Ivanov wrote:
> currently simply checking if $ESP_LIST exists, and indicating via
> the exit status if proxmox-boot-tool is used for booting the system.
>=20
> Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
> ---
> bin/proxmox-boot-tool | 20 ++++++++++++++++++++
> 1 file changed, 20 insertions(+)
>=20
> diff --git a/bin/proxmox-boot-tool b/bin/proxmox-boot-tool
> index 2d625a6..7b06d57 100755
> --- a/bin/proxmox-boot-tool
> +++ b/bin/proxmox-boot-tool
> @@ -283,6 +283,7 @@ usage() {
> warn " $0 refresh [--hook <name>]"
> warn " $0 kernel <add|remove> <kernel-version>"
> warn " $0 kernel list"
> + warn " $0 status"
> warn " $0 help"
> }
> =20
> @@ -312,6 +313,20 @@ help() {
> echo ""
> echo " list kernel versions currently selected for inclusion on ESPs=
."
> echo ""
> + echo "USAGE: $0 status [--verbose]"
> + echo ""
> + echo " Exit with 0 if any ESP is configured, else with 2."
> + echo ""
> +}
> +
> +status() {
> + verbose=3D"$1"
> + if [ ! -e ${ESP_LIST} ]; then
> + if [ -n "$verbose" ]; then
> + warn "E: $ESP_LIST does not exist."
this is a bit strange (a command called status that has a verbose flag=20
that does not output anything if everything is okay). maybe we could=20
list the ESPs? or even, if --verbose is given, mount them and print=20
THEIR status? ANY output would be great as a start ;)
> + fi
> + exit 2
> + fi
> }
> =20
> if [ -z "$1" ]; then
> @@ -390,6 +405,11 @@ case "$1" in
> ;;
> esac
> ;;
> + 'status')
> + shift
> + status "$1"
> + exit 0
> + ;;
> 'help')
> shift
> help
> --=20
> 2.20.1
>=20
>=20
>=20
> _______________________________________________
> pve-devel mailing list
> pve-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
>=20
>=20
>=20
=