From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 719486709C for ; Wed, 29 Jul 2020 14:04:51 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 666E1E6C4 for ; Wed, 29 Jul 2020 14:04:51 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id AD787E6B7 for ; Wed, 29 Jul 2020 14:04:49 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 75146433D5 for ; Wed, 29 Jul 2020 14:04:49 +0200 (CEST) Date: Wed, 29 Jul 2020 14:04:42 +0200 From: Fabian =?iso-8859-1?q?Gr=FCnbichler?= To: Proxmox VE development discussion References: <20200729065139.7774-1-d.csapak@proxmox.com> <1596017628.od73ai0k9w.astroid@nora.none> <134b3847-0a9e-8e42-eb60-54154d9a9535@proxmox.com> In-Reply-To: <134b3847-0a9e-8e42-eb60-54154d9a9535@proxmox.com> MIME-Version: 1.0 User-Agent: astroid/0.15.0 (https://github.com/astroidmail/astroid) Message-Id: <1596024074.3ucmem5j1d.astroid@nora.none> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-SPAM-LEVEL: Spam detection results: 0 AWL -0.360 Adjusted score from AWL reputation of From: address KAM_ASCII_DIVIDERS 0.8 Spam that uses ascii formatting tricks KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox.com, defines.mk] Subject: Re: [pve-devel] [PATCH manager] ui: reorder Makefile entries X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Jul 2020 12:04:51 -0000 On July 29, 2020 1:37 pm, Dominik Csapak wrote: > On 7/29/20 12:14 PM, Fabian Gr=C3=BCnbichler wrote: >> On July 29, 2020 8:51 am, Dominik Csapak wrote: >>> most of the time alphabetically is ok, but some classes have to defined >>> earlier, else extjs does not find the class and tries to dynamically >>> load it via a http request. that fails, and in the end it still >>> finds the right classes (after loading the complete js file) but >>> we still get ugly error messages and http requests that are not necessa= ry >>> >>> so we move some essential classes to the top >>> >>> Signed-off-by: Dominik Csapak >>> --- >>> has someone a better suggestion except manually managing the order? >>=20 >> split the list into two variables? one for the essential stuff with a >> comment, one for the sorted everything else.. >=20 > well they all depend on each other, the rest just works > by accident, so adding a new one could mean we have to > move a bunch to the other variable... write a script that concats them in the right order, keep the list=20 sorted in Makefile? ;) >=20 >>=20 >>> www/manager6/Makefile | 8 ++++---- >>> 1 file changed, 4 insertions(+), 4 deletions(-) >>> >>> diff --git a/www/manager6/Makefile b/www/manager6/Makefile >>> index 4288acdd..bccd8c32 100644 >>> --- a/www/manager6/Makefile >>> +++ b/www/manager6/Makefile >>> @@ -1,6 +1,9 @@ >>> include ../../defines.mk >>> =20 >>> JSSRC=3D \ >>> + panel/ConfigPanel.js \ >>> + panel/StatusView.js \ >>> + window/Wizard.js \ >>> Parser.js \ >>> StateProvider.js \ >>> Toolkit.js \ >>> @@ -29,8 +32,8 @@ JSSRC=3D \ >>> dc/ACLView.js \ >>> dc/ACMEClusterView.js \ >>> dc/ACMEPluginEdit.js \ >>> - dc/AuthEditAD.js \ >>> dc/AuthEditBase.js \ >>> + dc/AuthEditAD.js \ >>> dc/AuthEditLDAP.js \ >>> dc/AuthView.js \ >>> dc/Backup.js \ >>> @@ -154,7 +157,6 @@ JSSRC=3D \ >>> node/Subscription.js \ >>> node/Summary.js \ >>> node/ZFS.js \ >>> - panel/ConfigPanel.js \ >>> panel/GuestStatusView.js \ >>> panel/GuestSummary.js \ >>> panel/HealthWidget.js \ >>> @@ -163,7 +165,6 @@ JSSRC=3D \ >>> panel/NotesView.js \ >>> panel/RunningChart.js \ >>> panel/StatusPanel.js \ >>> - panel/StatusView.js \ >>> panel/TemplateStatusView.js \ >>> pool/Config.js \ >>> pool/StatusView.js \ >>> @@ -251,7 +252,6 @@ JSSRC=3D \ >>> window/Settings.js \ >>> window/Snapshot.js \ >>> window/StartupEdit.js \ >>> - window/Wizard.js \ >>> # end of JSSRC list >>> =20 >>> all: pvemanagerlib.js >>> --=20 >>> 2.20.1 >>> >>> >>> >>> _______________________________________________ >>> pve-devel mailing list >>> pve-devel@lists.proxmox.com >>> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel >>> >>> >>> >>=20 >>=20 >> _______________________________________________ >> pve-devel mailing list >> pve-devel@lists.proxmox.com >> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel >>=20 >>=20 >=20 >=20 >=20 > _______________________________________________ > pve-devel mailing list > pve-devel@lists.proxmox.com > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel >=20 =