From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id DA4D11FF0DF for ; Thu, 05 Nov 2026 15:51:54 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 4B596215B2; Thu, 05 Nov 2026 15:51:53 +0100 (CET) Message-ID: <14c708dc-38ea-467f-b544-f30c41c379b6@proxmox.com> Date: Thu, 5 Nov 2026 15:51:49 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH proxmox-firewall 07/13] firewall config: switch to proxmox-iproute2 crate To: Stefan Hanreich , pve-devel@lists.proxmox.com References: <20260617111012.312710-1-s.hanreich@proxmox.com> <20260617111012.312710-8-s.hanreich@proxmox.com> From: Hannes Laimer Content-Language: en-US In-Reply-To: <20260617111012.312710-8-s.hanreich@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1793890309396 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.298 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: KB22BGOFZFVFDRSYYFF57UZVVSSTKWBO X-Message-ID-Hash: KB22BGOFZFVFDRSYYFF57UZVVSSTKWBO X-MailFrom: h.laimer@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: proxmox-firewall/tests/integration_tests.rs still has a `use proxmox_network_api::AltnameMapping;` On 2026-06-17 13:10, Stefan Hanreich wrote: > Signed-off-by: Stefan Hanreich > --- > Cargo.toml | 2 +- > proxmox-firewall/Cargo.toml | 2 +- > proxmox-firewall/src/config.rs | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/Cargo.toml b/Cargo.toml > index 1dd2784..b44daae 100644 > --- a/Cargo.toml > +++ b/Cargo.toml > @@ -29,7 +29,7 @@ thiserror = "2" > > # proxmox dependencies > proxmox-log = "1" > -proxmox-network-api = "1" > +proxmox-iproute2 = "0.1.0" > proxmox-network-types = "1" > proxmox-serde = "1" > proxmox-sys = "1" > diff --git a/proxmox-firewall/Cargo.toml b/proxmox-firewall/Cargo.toml > index 6ad7e79..edb497d 100644 > --- a/proxmox-firewall/Cargo.toml > +++ b/proxmox-firewall/Cargo.toml > @@ -19,8 +19,8 @@ serde_json.workspace = true > signal-hook.workspace = true > > proxmox-log.workspace = true > +proxmox-iproute2.workspace = true > proxmox-network-types.workspace = true > -proxmox-network-api = { workspace = true, features = [ "impl" ] } > proxmox-nftables = { workspace = true, features = [ "config-ext" ] } > proxmox-ve-config.workspace = true > > diff --git a/proxmox-firewall/src/config.rs b/proxmox-firewall/src/config.rs > index 341e05a..57433a0 100644 > --- a/proxmox-firewall/src/config.rs > +++ b/proxmox-firewall/src/config.rs > @@ -19,7 +19,7 @@ use proxmox_ve_config::guest::types::Vmid; > use proxmox_ve_config::guest::{GuestEntry, GuestMap}; > use proxmox_ve_config::host::types::BridgeName; > > -use proxmox_network_api::{AltnameMapping, get_network_interfaces}; > +use proxmox_iproute2::{AltnameMapping, get_network_interfaces}; > use proxmox_nftables::NftClient; > use proxmox_nftables::command::{CommandOutput, Commands, List, ListOutput}; > use proxmox_nftables::types::ListChain;