From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 462BC1FF180 for ; Fri, 1 Aug 2025 08:37:24 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 768EA10889; Fri, 1 Aug 2025 08:38:50 +0200 (CEST) Message-ID: <141b96fb-fdb3-4f0a-941e-0cfb76393797@proxmox.com> Date: Fri, 1 Aug 2025 08:38:16 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta To: Proxmox VE development discussion , Gabriel Goller References: <20250731155846.277381-1-g.goller@proxmox.com> Content-Language: en-US From: Thomas Lamprecht In-Reply-To: <20250731155846.277381-1-g.goller@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1754030283465 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.803 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NUMERIC_HTTP_ADDR 1.242 Uses a numeric IP address in URL POISEN_SPAM_PILL 0.1 Meta: its spam POISEN_SPAM_PILL_1 0.1 random spam to be learned in bayes POISEN_SPAM_PILL_3 0.1 random spam to be learned in bayes RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record WEIRD_PORT 0.001 Uses non-standard port number for HTTP Subject: Re: [pve-devel] [RFC PATCH manager] migrate: fix conntrack migration and ha-resources checkbox X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" Am 31.07.25 um 17:58 schrieb Gabriel Goller: > The checkbox wasn't displayed and following errors were on the console: > > failed to query /capabilites/qemu/migration on '': [object Object] pvemanagerlib.js:20401:25 > Uncaught (in promise) TypeError: comigratedHAResources is not iterable > checkQemuPreconditions https://172.16.0.18:8006/pve2/js/pvemanagerlib.js?ver=9.0.0~17:20595 > > Error is an object, so we need to print it in the next line, otherwise > only [object Object] is shown. Check if comigratedHAResources is > iterable, otherwise don't iterate over it. > > Signed-off-by: Gabriel Goller > --- > > Tested this quickly but no idea if it's correct. Maybe Daniel and > Christoph could have a look at it. > > www/manager6/window/Migrate.js | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/www/manager6/window/Migrate.js b/www/manager6/window/Migrate.js > index b5ecb9603cf1..c884fbddd1aa 100644 > --- a/www/manager6/window/Migrate.js > +++ b/www/manager6/window/Migrate.js > @@ -254,7 +254,8 @@ Ext.define('PVE.window.Migrate', { > } catch (err) { > // Only emit a warning in the case the target node does not (yet) support the > // `capabilites/qemu/migration` endpoint and simply treat all features as unsupported. > - console.warn(`failed to query /capabilites/qemu/migration on '${target}': ${err}`); FWIW, could be also done by moving it out from the template string to a separate param: console.warn(`failed to query /capabilites/qemu/migration on '${target}':`, err); > + console.warn(`failed to query /capabilites/qemu/migration on '${target}':`); > + console.warn(err); > } > > me.fetchingNodeMigrateInfo = false; > @@ -447,7 +448,7 @@ Ext.define('PVE.window.Migrate', { > } > > let comigratedHAResources = migrateStats['comigrated-ha-resources']; > - if (comigratedHAResources !== undefined) { > + if (comigratedHAResources !== undefined && typeof comigratedHAResources[Symbol.iterator] === 'function') { If it exists this is always an array per the schema though, so the following might be enough: if (typeof comigratedHAResources === 'array') { Or use the ExtJS frameworks' Ext.isIterable() while under the hood it's a bit more heuristic than your check, it should cover all (for us) relevant cases if (Ext.isIterable(comigratedHAResources)) { Your variant might be fine as Proxmox.Utils method though, but rather overkill for now. > for (const sid of comigratedHAResources) { > const text = Ext.String.format( > gettext( _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel