From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <d.csapak@proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id A9B519F989 for <pbs-devel@lists.proxmox.com>; Tue, 7 Nov 2023 10:01:46 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 8787E1F3D1 for <pbs-devel@lists.proxmox.com>; Tue, 7 Nov 2023 10:01:16 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for <pbs-devel@lists.proxmox.com>; Tue, 7 Nov 2023 10:01:15 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 9E24446E3F; Tue, 7 Nov 2023 10:01:15 +0100 (CET) Message-ID: <13b9a357-27f1-476d-868b-8f8fd76f49f0@proxmox.com> Date: Tue, 7 Nov 2023 10:01:15 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta Content-Language: en-US To: Proxmox Backup Server development discussion <pbs-devel@lists.proxmox.com>, Wolfgang Bumiller <w.bumiller@proxmox.com>, Thomas Lamprecht <t.lamprecht@proxmox.com> References: <20231023154302.2558918-2-p.hufnagl@proxmox.com> <54f6b050-02ce-4443-a3f3-e28ee2b875bd@proxmox.com> <fb844e0d-26ad-4a7c-a8e5-5d99c29c7b01@proxmox.com> <d9a94b91-e13a-470e-87c9-a600d7cb9d10@proxmox.com> <dc0cc081-ee54-4016-af3f-9a372faba9d1@proxmox.com> <69df7927-de20-4301-a785-2a57d53fcf2b@proxmox.com> <b42c40b6-b8f9-4269-9440-d527fb940b97@proxmox.com> <1b0eec17-d519-4d80-89f6-e08b9738fcd8@proxmox.com> <skraqtvbzlpulrr4u2joslsui7mhce2sichjefpnapbidspcjr@a3c4s3zmq7oy> <ae228735-6ea8-4f49-94f8-1da29c091c77@proxmox.com> <25pvugernovezgv6u7qw7xiucsfkvbieizj7cija7aftln74ww@fopnbametx46> From: Dominik Csapak <d.csapak@proxmox.com> In-Reply-To: <25pvugernovezgv6u7qw7xiucsfkvbieizj7cija7aftln74ww@fopnbametx46> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.017 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pbs-devel] [PATCH proxmox-backup 1/3] fix #4315: jobs: modify GroupFilter so include/exclude is tracked X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion <pbs-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pbs-devel>, <mailto:pbs-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pbs-devel/> List-Post: <mailto:pbs-devel@lists.proxmox.com> List-Help: <mailto:pbs-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel>, <mailto:pbs-devel-request@lists.proxmox.com?subject=subscribe> X-List-Received-Date: Tue, 07 Nov 2023 09:01:46 -0000 just to chime in here to the discussion order/not order: (writing mostly so that it is public record ;) ) if we want it to keep it *really* simple, we could ditch the whole mixing of include/exclude completely and make it *either* , so add a flag 'groups are excluding' and if people want to do more complex things, they have to setup multiple sync jobs (e.g. the 'exclude 1-100 except 50' example would be one job excluding 1-100 and another only including 50)