From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 80B7F1FF16B for ; Tue, 29 Jul 2025 19:16:27 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id B44CD1964A; Tue, 29 Jul 2025 19:17:52 +0200 (CEST) Message-ID: <139d7623-2439-43a2-9d89-c5c6d2993f41@proxmox.com> Date: Tue, 29 Jul 2025 19:17:48 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: pve-devel@lists.proxmox.com References: <20250724144959.374061-1-s.hanreich@proxmox.com> Content-Language: en-US From: Stefan Hanreich In-Reply-To: <20250724144959.374061-1-s.hanreich@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.704 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [pullmetric.pm, proxmox.com, pvestatd.pm, inotify.pm] Subject: [pve-devel] superseded: [RFC common/manager 0/3] arbitrary prefixes for pinning network interfaces X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" https://lore.proxmox.com/pve-devel/20250729171649.708219-1-s.hanreich@proxmox.com/T/#t On 7/24/25 4:49 PM, Stefan Hanreich wrote: > This patch series lifts the restriction for naming physical interfaces. > Previously we relied on a regex (PHYSICAL_NIC_RE) for determining whether an > interface was physical or not. This patch series changes that, by querying the > kernel for the type of the interface and using that to determine whether an > interface is a physical interface or not. This allows us to use arbitrary names > for physical interfaces, which in turn allows proxmox-network-interface-pinning > to use arbitrary prefixes / target-names when pinning network interfaces. > > The main change here is with pvestatd and metric collection, where we used the > regex to determine the type of interface in PullMetric. I introduced a new key > in the netdev hash that indicates the type of interface. Since my knowledge of > this component is almost zero, I'm not sure if this is the proper approach. > Maybe someone with more experience can chime in on possible issues / > improvements. > > This patch series applies on top of my previous series that improves several > aspects of the pinning tool [1]. > > pve-manager depends on pve-common > > [1] https://lore.proxmox.com/pve-devel/20250724093459.76397-1-s.hanreich@proxmox.com/T/#t > > pve-common: > > Stefan Hanreich (1): > inotify/interfaces: use ip link for detecting physical interfaces > > src/PVE/INotify.pm | 25 +++++++++++++------------ > 1 file changed, 13 insertions(+), 12 deletions(-) > > > pve-manager: > > Stefan Hanreich (2): > pvestatd: pull metric: use ip link to detect physical interfaces > network-interface-pinning: allow arbitrary names > > PVE/CLI/proxmox_network_interface_pinning.pm | 7 ++++--- > PVE/PullMetric.pm | 15 ++++++++++++--- > PVE/Service/pvestatd.pm | 13 ++++++++++++- > 3 files changed, 28 insertions(+), 7 deletions(-) > > > Summary over all repositories: > 4 files changed, 41 insertions(+), 19 deletions(-) > _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel