From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <t.lamprecht@proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by lists.proxmox.com (Postfix) with ESMTPS id 2BDFA75617
 for <pbs-devel@lists.proxmox.com>; Mon, 12 Jul 2021 18:20:44 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
 by firstgate.proxmox.com (Proxmox) with ESMTP id 2923418831
 for <pbs-devel@lists.proxmox.com>; Mon, 12 Jul 2021 18:20:44 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com
 [94.136.29.106])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by firstgate.proxmox.com (Proxmox) with ESMTPS id 7AFAD18823
 for <pbs-devel@lists.proxmox.com>; Mon, 12 Jul 2021 18:20:43 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])
 by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 54E3841016
 for <pbs-devel@lists.proxmox.com>; Mon, 12 Jul 2021 18:20:43 +0200 (CEST)
Message-ID: <12b79b42-a8d9-1ace-b8f3-8f46f1bca9ef@proxmox.com>
Date: Mon, 12 Jul 2021 18:20:21 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:90.0) Gecko/20100101
 Thunderbird/90.0
Content-Language: en-US
To: Proxmox Backup Server development discussion
 <pbs-devel@lists.proxmox.com>, Dietmar Maurer <dietmar@proxmox.com>
References: <20210712154853.266573-1-dietmar@proxmox.com>
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
In-Reply-To: <20210712154853.266573-1-dietmar@proxmox.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-SPAM-LEVEL: Spam detection results:  0
 AWL 0.464 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_PASS               -0.001 SPF: sender matches SPF record
Subject: [pbs-devel] applied: [PATCH proxmox-backup v2] tape: changer:
 sg_pt: query element types separately
X-BeenThere: pbs-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox Backup Server development discussion
 <pbs-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pbs-devel>, 
 <mailto:pbs-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pbs-devel/>
List-Post: <mailto:pbs-devel@lists.proxmox.com>
List-Help: <mailto:pbs-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel>, 
 <mailto:pbs-devel-request@lists.proxmox.com?subject=subscribe>
X-List-Received-Date: Mon, 12 Jul 2021 16:20:44 -0000

On 12.07.21 17:48, Dietmar Maurer wrote:
> From: Dominik Csapak <d.csapak@proxmox.com>
> 
> Some changers do not like the DVCID bit when querying non-drives,
> this includes when querying 'all' elements.
> 
> To circumvent this, we query each type by itself (like mtx does it),
> and only add the DVCID bit for drives (Data Transfer Elements).
> 
> Reported by a user in the forum:
> https://forum.proxmox.com/threads/ibm-3584-ts3500-support.92291/
> 
> and limit to 1000 elements per request.
> (Because some changers limit that request with the options we set)
> 
> instead of checking if the data len was equal to the allocation_len
> for getting more data, we count the returned elements and compare
> that with the number we requested
> 
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> Signed-off-by: Dietmar Maurer <dietmar@proxmox.com>
> ---
>  src/tape/changer/sg_pt_changer.rs | 112 +++++++++++++++++++++---------
>  1 file changed, 80 insertions(+), 32 deletions(-)
> 
>

applied, thanks!