From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <pbs-devel-bounces@lists.proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 9B6B01FF38C for <inbox@lore.proxmox.com>; Fri, 31 May 2024 13:20:03 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 4C2B333D1F; Fri, 31 May 2024 13:20:29 +0200 (CEST) Content-Type: multipart/mixed; boundary="------------t8yopA8rtf8BkuCVW42QCUKa" Message-ID: <12ad5469-f33f-46ef-838c-63df87d83878@proxmox.com> Date: Fri, 31 May 2024 13:19:56 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Proxmox Backup Server development discussion <pbs-devel@lists.proxmox.com>, Dominik Csapak <d.csapak@proxmox.com> References: <20240528094303.309806-1-c.ebner@proxmox.com> <1e55b198-49b6-4555-b633-852ebd71b42b@proxmox.com> Content-Language: en-US, de-DE From: Christian Ebner <c.ebner@proxmox.com> In-Reply-To: <1e55b198-49b6-4555-b633-852ebd71b42b@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.028 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [create.rs] Subject: Re: [pbs-devel] [PATCH v8 pxar proxmox-backup 00/69] fix #3174: improve file-level backup X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion <pbs-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pbs-devel>, <mailto:pbs-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pbs-devel/> List-Post: <mailto:pbs-devel@lists.proxmox.com> List-Help: <mailto:pbs-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel>, <mailto:pbs-devel-request@lists.proxmox.com?subject=subscribe> Reply-To: Proxmox Backup Server development discussion <pbs-devel@lists.proxmox.com> Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" <pbs-devel-bounces@lists.proxmox.com> This is a multi-part message in MIME format. --------------t8yopA8rtf8BkuCVW42QCUKa Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 5/31/24 12:40, Dominik Csapak wrote: > for reference, as discussed off-list > > there seems to be an issue (with this version at least, not sure if it's > actually a regression) > that does not correctly reuse entries after encountering a changed file > > (changed 1 file + added one file (~20MiB) and only ~600 out of ~500000 > (~10GiB) were reused) Thanks for reporting this and swift help to find the underlying issue Dominik! The fix will be included in an upcoming version 9 of the patches, I still want to wait a bit for eventual further feedback before spamming the mailing list with to many intermediate iterations. For now, the attached patch can be applied as followup to the series to fix this issue. --------------t8yopA8rtf8BkuCVW42QCUKa Content-Type: text/x-diff; charset=UTF-8; name="0001-client-pxar-conditional-flushing-of-cached-entries.patch" Content-Disposition: attachment; filename*0="0001-client-pxar-conditional-flushing-of-cached-entries.patc"; filename*1="h" Content-Transfer-Encoding: base64 RnJvbSAxOGU4YjY4Njg3ODA4NjllOWQ0NjI5MmI3M2E1NjY4N2NhNDQ0ODNiIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBDaHJpc3RpYW4gRWJuZXIgPGMuZWJuZXJAcHJveG1v eC5jb20+CkRhdGU6IEZyaSwgMzEgTWF5IDIwMjQgMTM6MDc6NTIgKzAyMDAKU3ViamVjdDog W1BBVENIIHByb3htb3gtYmFja3VwXSBjbGllbnQ6IHB4YXI6IGNvbmRpdGlvbmFsIGZsdXNo aW5nIG9mIGNhY2hlZAogZW50cmllcwoKRW50cmllcyB3aXRoIHVuY2hhbmdlZCBtZXRhZGF0 YSBhcmUgcGxhY2VkIG9uIHRoZSBsb29rYWhlYWQgY2FjaGUgaW4Kb3JkZXIgdG8gcG9zdHBv bmUgYSBkZWNpdGlvbiB3aGV0aGVyIHRvIHJldXNlIG9yIHJlZW5jb2RlIHRoZQplbnRyaWVz LiBJbiBjYXNlIG9mIGEgbm9uLXJldXNhYmxlIGVudHJ5LCB0aGUgY2FjaGVkIGVudHJpZXMg bXVzdCBiZQpyZWVuY29kZWQgaWYgdGhlaXIgcGFkZGluZyBleGNlZWRzIHRoZSB0aHJlc2hv bGQsIHRoZXkgc2hvdWxkIGhvd2V2ZXIKYmUgcmV1c2VkIG90aGVyd2lzZS4KVGhpcyBwYXRj aCBhZGRzIHRoZSBtaXNzaW5nIGNoZWNrIHRvIGFsbG93IHRoZSByZXVzZSBvZiBjYWNoZWQK ZW50cmllcyBpbiBzdWNoIGEgY2FzZS4KClNpZ25lZC1vZmYtYnk6IENocmlzdGlhbiBFYm5l ciA8Yy5lYm5lckBwcm94bW94LmNvbT4KLS0tCiBwYnMtY2xpZW50L3NyYy9weGFyL2NyZWF0 ZS5ycyB8IDMgKysrCiAxIGZpbGUgY2hhbmdlZCwgMyBpbnNlcnRpb25zKCspCgpkaWZmIC0t Z2l0IGEvcGJzLWNsaWVudC9zcmMvcHhhci9jcmVhdGUucnMgYi9wYnMtY2xpZW50L3NyYy9w eGFyL2NyZWF0ZS5ycwppbmRleCBjMzBiYTM0MGYuLmRhNzgwN2I0OSAxMDA2NDQKLS0tIGEv cGJzLWNsaWVudC9zcmMvcHhhci9jcmVhdGUucnMKKysrIGIvcGJzLWNsaWVudC9zcmMvcHhh ci9jcmVhdGUucnMKQEAgLTc5MSw2ICs3OTEsOSBAQCBpbXBsIEFyY2hpdmVyIHsKICAgICAg ICAgICAgICAgICBzZWxmLmNhY2hlCiAgICAgICAgICAgICAgICAgICAgIC5pbnNlcnQoZmQs IGNfZmlsZV9uYW1lLmludG8oKSwgKnN0YXQsIG1ldGFkYXRhLmNsb25lKCksIG9mZnNldCk7 CiAgICAgICAgICAgICAgICAgcmV0dXJuIE9rKCgpKTsKKyAgICAgICAgICAgIH0gZWxzZSB7 CisgICAgICAgICAgICAgICAgc2VsZi5mbHVzaF9jYWNoZWRfcmV1c2luZ19pZl9iZWxvd190 aHJlc2hvbGQoZW5jb2RlciwgZmFsc2UpCisgICAgICAgICAgICAgICAgICAgIC5hd2FpdD87 CiAgICAgICAgICAgICB9CiAgICAgICAgIH0gZWxzZSBpZiBzZWxmLmNhY2hlLmNhY2hpbmdf ZW5hYmxlZCgpIHsKICAgICAgICAgICAgIHNlbGYuY2FjaGUuaW5zZXJ0KAotLSAKMi4zOS4y Cgo= --------------t8yopA8rtf8BkuCVW42QCUKa Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel --------------t8yopA8rtf8BkuCVW42QCUKa--