From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
	by lore.proxmox.com (Postfix) with ESMTPS id 61D4A1FF168
	for <inbox@lore.proxmox.com>; Mon, 14 Oct 2024 14:37:51 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
	by firstgate.proxmox.com (Proxmox) with ESMTP id DBDAA3486E;
	Mon, 14 Oct 2024 14:38:21 +0200 (CEST)
Message-ID: <12262a12-03cc-4b08-9be7-9f6ddf715ff1@proxmox.com>
Date: Mon, 14 Oct 2024 14:38:18 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird Beta
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
 Timothy Nicholson <t.nicholson@proxmox.com>
References: <20241014122603.126568-1-t.nicholson@proxmox.com>
Content-Language: en-US
From: Dominik Csapak <d.csapak@proxmox.com>
In-Reply-To: <20241014122603.126568-1-t.nicholson@proxmox.com>
X-SPAM-LEVEL: Spam detection results:  0
 AWL 0.016 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 DMARC_MISSING             0.1 Missing DMARC policy
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
 Validity was blocked. See
 https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
 information.
 RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
 Validity was blocked. See
 https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
 information.
 RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
 Validity was blocked. See
 https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
 information.
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_PASS               -0.001 SPF: sender matches SPF record
Subject: Re: [pve-devel] [PATCH pve-manager] fix #5302: ui: vm cpu affinity
 displayed in hardware overview
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Errors-To: pve-devel-bounces@lists.proxmox.com
Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com>

Hi,

Looks mostly good to me, aside from the indentation (as mentioned off-list)
so please send a v2 with the indentation fixed,

thanks

On 10/14/24 14:26, Timothy Nicholson wrote:
> Signed-off-by: Timothy Nicholson <t.nicholson@proxmox.com>
> ---
>   www/manager6/qemu/HardwareView.js | 11 +++++++++--
>   1 file changed, 9 insertions(+), 2 deletions(-)
> 
> diff --git a/www/manager6/qemu/HardwareView.js b/www/manager6/qemu/HardwareView.js
> index 86d5f4cf..b607265a 100644
> --- a/www/manager6/qemu/HardwareView.js
> +++ b/www/manager6/qemu/HardwareView.js
> @@ -103,7 +103,7 @@ Ext.define('PVE.qemu.HardwareView', {
>   		tdCls: 'pve-itype-icon-cpu',
>   		group: 3,
>   		defaultValue: '1',
> -		multiKey: ['sockets', 'cpu', 'cores', 'numa', 'vcpus', 'cpulimit', 'cpuunits'],
> +		multiKey: ['sockets', 'cpu', 'cores', 'numa', 'vcpus', 'cpulimit', 'cpuunits', 'affinity'],
>   		renderer: function(value, metaData, record, rowIndex, colIndex, store, pending) {
>   		    var sockets = me.getObjectValue('sockets', 1, pending);
>   		    var model = me.getObjectValue('cpu', undefined, pending);
> @@ -112,6 +112,7 @@ Ext.define('PVE.qemu.HardwareView', {
>   		    var vcpus = me.getObjectValue('vcpus', undefined, pending);
>   		    var cpulimit = me.getObjectValue('cpulimit', undefined, pending);
>   		    var cpuunits = me.getObjectValue('cpuunits', undefined, pending);
> +                    var cpuaffinity = me.getObjectValue('affinity', undefined, pending);
>   
>   		    let res = Ext.String.format(
>   		        '{0} ({1} sockets, {2} cores)', sockets * cores, sockets, cores);
> @@ -131,7 +132,10 @@ Ext.define('PVE.qemu.HardwareView', {
>   		    if (cpuunits) {
>   			res += ' [cpuunits=' + cpuunits +']';
>   		    }
> -
> +                    if (cpuaffinity) {
> +                        res += ' [cpuaffinity=' + cpuaffinity + ']';
> +                    }
> +
>   		    return res;
>   		},
>   	    },
> @@ -214,6 +218,9 @@ Ext.define('PVE.qemu.HardwareView', {
>   	    ostype: {
>   		visible: false,
>   	    },
> +            affinity: {
> +                visible: false,
> +            },
>   	};
>   
>   	PVE.Utils.forEachBus(undefined, function(type, id) {



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel