From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <aderumier@odiso.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 520546247E for <pve-devel@lists.proxmox.com>; Wed, 30 Sep 2020 08:09:20 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 4142A14DA1 for <pve-devel@lists.proxmox.com>; Wed, 30 Sep 2020 08:09:20 +0200 (CEST) Received: from mailpro.odiso.net (mailpro.odiso.net [89.248.211.110]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 86E3414D94 for <pve-devel@lists.proxmox.com>; Wed, 30 Sep 2020 08:09:17 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by mailpro.odiso.net (Postfix) with ESMTP id 9EB64F8AC6A for <pve-devel@lists.proxmox.com>; Wed, 30 Sep 2020 08:09:15 +0200 (CEST) Received: from mailpro.odiso.net ([127.0.0.1]) by localhost (mailpro.odiso.net [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id YYEXSqmDQubF for <pve-devel@lists.proxmox.com>; Wed, 30 Sep 2020 08:09:15 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by mailpro.odiso.net (Postfix) with ESMTP id 8340FF8AC6B for <pve-devel@lists.proxmox.com>; Wed, 30 Sep 2020 08:09:15 +0200 (CEST) X-Virus-Scanned: amavisd-new at mailpro.odiso.com Received: from mailpro.odiso.net ([127.0.0.1]) by localhost (mailpro.odiso.net [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id KsHnay1iepn5 for <pve-devel@lists.proxmox.com>; Wed, 30 Sep 2020 08:09:15 +0200 (CEST) Received: from mailpro.odiso.net (mailpro.odiso.net [10.1.31.111]) by mailpro.odiso.net (Postfix) with ESMTP id 6EE6AF8AC6A for <pve-devel@lists.proxmox.com>; Wed, 30 Sep 2020 08:09:15 +0200 (CEST) Date: Wed, 30 Sep 2020 08:09:15 +0200 (CEST) From: Alexandre DERUMIER <aderumier@odiso.com> To: Proxmox VE development discussion <pve-devel@lists.proxmox.com> Message-ID: <1030723475.2207793.1601446155192.JavaMail.zimbra@odiso.com> In-Reply-To: <2038102437.1994930.1601387538948.JavaMail.zimbra@odiso.com> References: <216436814.339545.1599142316781.JavaMail.zimbra@odiso.com> <1601368526.gv9th0ekl0.astroid@nora.none> <1140250655.1944706.1601372261446.JavaMail.zimbra@odiso.com> <1740926248.1973796.1601376764334.JavaMail.zimbra@odiso.com> <596957573.1989195.1601379788390.JavaMail.zimbra@odiso.com> <528275552.1989337.1601380258730.JavaMail.zimbra@odiso.com> <1601385859.kkbi3kzm1m.astroid@nora.none> <2038102437.1994930.1601387538948.JavaMail.zimbra@odiso.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Mailer: Zimbra 8.8.12_GA_3866 (ZimbraWebClient - GC83 (Linux)/8.8.12_GA_3844) Thread-Topic: corosync bug: cluster break after 1 node clean shutdown Thread-Index: D+OaKBh5GPTYmKFVj9B97WJGEUh1azqyi4R4 X-SPAM-LEVEL: Spam detection results: 1 AWL -0.030 Adjusted score from AWL reputation of From: address KAM_ASCII_DIVIDERS 0.8 Spam that uses ascii formatting tricks KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_LOTSOFHASH 0.25 Emails with lots of hash-like gibberish RCVD_IN_DNSWL_NONE -0.0001 Sender listed at https://www.dnswl.org/, no trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox.com] Subject: Re: [pve-devel] corosync bug: cluster break after 1 node clean shutdown X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> X-List-Received-Date: Wed, 30 Sep 2020 06:09:20 -0000 Hi, some news, my last test is running for 14h now, and I don't have had any pr= oblem :) So, it seem that is indeed fixed ! Congratulations ! I wonder if it could be related to this forum user https://forum.proxmox.com/threads/proxmox-6-2-corosync-3-rare-and-spontaneo= us-disruptive-udp-5405-storm-flood.75871/ His problem is that after corosync lag (he's have 1 cluster stretch on 2DC = with 10km distance, so I think sometimes he's having some small lag, 1 node is flooding other nodes with a lot of udp packets. (and making thing= s worst, as corosync cpu is going to 100% / overloaded, and then can't see = other onodes I had this problem 6month ago after shutting down a node, that's why I'm th= inking it could "maybe" related. So, I wonder if it could be same pmxcfs bug, when something looping or send= again again packets. The forum user seem to have the problem multiple times in some week, so may= be he'll be able to test the new fixed pmxcs, and tell us if it's fixing th= is bug too. ----- Mail original ----- De: "aderumier" <aderumier@odiso.com> =C3=80: "Proxmox VE development discussion" <pve-devel@lists.proxmox.com> Envoy=C3=A9: Mardi 29 Septembre 2020 15:52:18 Objet: Re: [pve-devel] corosync bug: cluster break after 1 node clean shutd= own >>huge thanks for all the work on this btw!=20 huge thanks to you ! ;)=20 >>I think I've found a likely culprit (a missing lock around a=20 >>non-thread-safe corosync library call) based on the last logs (which=20 >>were now finally complete!).=20 YES :)=20 >>if feedback from your end is positive, I'll whip up a proper patch=20 >>tomorrow or on Thursday.=20 I'm going to launch a new test right now !=20 ----- Mail original -----=20 De: "Fabian Gr=C3=BCnbichler" <f.gruenbichler@proxmox.com>=20 =C3=80: "Proxmox VE development discussion" <pve-devel@lists.proxmox.com>= =20 Envoy=C3=A9: Mardi 29 Septembre 2020 15:28:19=20 Objet: Re: [pve-devel] corosync bug: cluster break after 1 node clean shutd= own=20 huge thanks for all the work on this btw!=20 I think I've found a likely culprit (a missing lock around a=20 non-thread-safe corosync library call) based on the last logs (which=20 were now finally complete!).=20 rebuilt packages with a proof-of-concept-fix:=20 23b03a48d3aa9c14e86fe8cf9bbb7b00bd8fe9483084b9e0fd75fd67f29f10bec00e317e2a6= 6758713050f36c165d72f107ee3449f9efeb842d3a57c25f8bca7 pve-cluster_6.1-8_amd= 64.deb=20 9e1addd676513b176f5afb67cc6d85630e7da9bbbf63562421b4fd2a3916b3b2af922df5550= 59b99f8b0b9e64171101a1c9973846e25f9144ded9d487450baef pve-cluster-dbgsym_6.= 1-8_amd64.deb=20 I removed some logging statements which are no longer needed, so output=20 is a bit less verbose again. if you are not able to trigger the issue=20 with this package, feel free to remove the -debug and let it run for a=20 little longer without the massive logs.=20 if feedback from your end is positive, I'll whip up a proper patch=20 tomorrow or on Thursday.=20 _______________________________________________=20 pve-devel mailing list=20 pve-devel@lists.proxmox.com=20 https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel=20 _______________________________________________=20 pve-devel mailing list=20 pve-devel@lists.proxmox.com=20 https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel=20