From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 1583C1FF140 for ; Fri, 27 Mar 2026 11:00:53 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 8B3C0246A; Fri, 27 Mar 2026 11:01:14 +0100 (CET) Message-ID: <10190bb5-ef04-4d4d-89a5-1b35d3a8f878@proxmox.com> Date: Fri, 27 Mar 2026 11:01:10 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH pve-network 07/13] api2: add route map entry module To: Hannes Laimer , pve-devel@lists.proxmox.com References: <20260325094142.174364-1-s.hanreich@proxmox.com> <20260325094142.174364-22-s.hanreich@proxmox.com> Content-Language: en-US From: Stefan Hanreich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.560 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment POISEN_SPAM_PILL 0.1 Meta: its spam POISEN_SPAM_PILL_1 0.1 random spam to be learned in bayes POISEN_SPAM_PILL_3 0.1 random spam to be learned in bayes RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: RSVGATUY6WO545BL22G7MJPXJUD3NM3B X-Message-ID-Hash: RSVGATUY6WO545BL22G7MJPXJUD3NM3B X-MailFrom: s.hanreich@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 3/26/26 4:12 PM, Hannes Laimer wrote: > On 2026-03-25 10:49, Stefan Hanreich wrote: >> This module contains the following API endpoints: >> >> GET /route-maps// - gets the order'th entry in route map >> >> PUT /route-maps// - updates the order'th entry in >> route map >> DELETE /route-maps// - deletes the order'th >> entry in route map >> >> Signed-off-by: Stefan Hanreich >> --- > > [..] > >> +__PACKAGE__->register_method({ >> + name => 'update_route_map_entry', >> + path => '', >> + method => 'PUT', >> + permissions => { >> + check => ['perm', '/sdn/route-maps/{route-map-id}', ['SDN.Allocate']], >> + }, >> + description => "Update Route Map Entry", >> + parameters => { >> + properties => { >> + digest => get_standard_option('pve-config-digest'), >> + 'lock-token' => get_standard_option('pve-sdn-lock-token'), >> + PVE::Network::SDN::RouteMaps::route_map_properties(1)->%*, >> + }, >> + }, >> + returns => { >> + type => "null", >> + }, >> + code => sub { >> + my ($param) = @_; >> + >> + my $lock_token = extract_param($param, 'lock-token'); >> + >> + PVE::Network::SDN::lock_sdn_config( >> + sub { >> + my $config = PVE::Network::SDN::RouteMaps::config(); >> + >> + my $digest = extract_param($param, 'digest'); >> + PVE::Tools::assert_if_modified($config->digest(), $digest) if $digest; >> + >> + my $route_map_id = extract_param($param, 'route-map-id'); >> + my $order = extract_param($param, 'order'); >> + my $delete = extract_param($param, 'delete'); >> + >> + $config->update($route_map_id, $order, $param); > > looks like the update call is missing the `.. , $delete);` good catch, fixed