From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <t.lamprecht@proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits))
(No client certificate requested)
by lists.proxmox.com (Postfix) with ESMTPS id DFD43883B
for <pve-devel@lists.proxmox.com>; Wed, 16 Nov 2022 09:59:51 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id C197A1C611
for <pve-devel@lists.proxmox.com>; Wed, 16 Nov 2022 09:59:21 +0100 (CET)
Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com
[94.136.29.106])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits))
(No client certificate requested)
by firstgate.proxmox.com (Proxmox) with ESMTPS
for <pve-devel@lists.proxmox.com>; Wed, 16 Nov 2022 09:59:21 +0100 (CET)
Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])
by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 17B69446A2
for <pve-devel@lists.proxmox.com>; Wed, 16 Nov 2022 09:59:21 +0100 (CET)
Message-ID: <0f5347aa-a9af-36c6-b1ce-0550f5bce6ef@proxmox.com>
Date: Wed, 16 Nov 2022 09:59:20 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:107.0) Gecko/20100101
Thunderbird/107.0
Content-Language: en-GB
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Fiona Ebner <f.ebner@proxmox.com>
References: <20221110143800.98047-1-f.ebner@proxmox.com>
<20221110143800.98047-12-f.ebner@proxmox.com>
<e3ebd7af-892a-f4d9-b104-1c6a172ea67f@proxmox.com>
<d08aa6df-0bdf-933e-fa62-25d9a17095ab@proxmox.com>
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
In-Reply-To: <d08aa6df-0bdf-933e-fa62-25d9a17095ab@proxmox.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-SPAM-LEVEL: Spam detection results: =?UTF-8?Q?0=0A=09?=AWL -0.031 Adjusted
score from AWL reputation of From: =?UTF-8?Q?address=0A=09?=BAYES_00 -1.9
Bayes spam probability is 0 to 1%
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict
=?UTF-8?Q?Alignment=0A=09?=NICE_REPLY_A -0.001 Looks like a legit reply (A)
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF
=?UTF-8?Q?Record=0A=09?=SPF_PASS -0.001 SPF: sender matches SPF record
Subject: Re: [pve-devel] [PATCH ha-manager 02/11] resources: add
get_static_stats() method
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
X-List-Received-Date: Wed, 16 Nov 2022 08:59:51 -0000
Am 16/11/2022 um 09:46 schrieb Fiona Ebner:
>>> + return {
>>> + maxcpu => $conf->{vcpus} || $cpus,
>>> + maxmem => ($conf->{memory} || $defaults->{memory}) * 1024 * 1024,
>> same here. As this is just internal we can also adapt it later though..
>>
> Well, the Rust backend also uses 'maxcpu' and 'maxmem' currently :/
> So at least in Usage/Static.pm, it will be more difficult to change later.
hmm then we should switch now (over never speak of this again ;), I'll survive
if it stays that way too, just mentioned it due to finding it harder to read
without real benefit.