From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id BAAB31FF165 for ; Thu, 9 Oct 2025 11:09:13 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 2551B1A064; Thu, 9 Oct 2025 11:09:20 +0200 (CEST) Message-ID: <0e7829a4-810d-43c8-8895-da0cd2c014a8@proxmox.com> Date: Thu, 9 Oct 2025 11:09:17 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta To: Proxmox Backup Server development discussion , Dominik Csapak References: <20251008134344.3512958-1-d.csapak@proxmox.com> <20251008134344.3512958-8-d.csapak@proxmox.com> <965ca958-d7ec-4d7e-aed0-d97acf22691d@proxmox.com> <76c5aac5-222a-48b3-b2a5-ffb98a4f79f9@proxmox.com> Content-Language: en-US From: Thomas Lamprecht In-Reply-To: <76c5aac5-222a-48b3-b2a5-ffb98a4f79f9@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1760000925467 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.025 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pbs-devel] [PATCH proxmox-backup v2 6/6] api: admin: datastore: implement streaming content api call X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" Am 09.10.25 um 11:03 schrieb Dominik Csapak: > > anyway, i measured the peak RSS (directly from procfs) while these api > calls were running: > > for an old 'snapshot listing' with the same datastore as mentioned before, the peak usage was ~446MiB, while on the newer content > streaming api (while streaming) was ~33MiB (which was about the > same as before and after the api call) > > so the memory usage for building the lists in memory takes about > 446-32 ~414MiB (for about 600.000 snapshots) Thanks for measuring, that difference looks quite nice! > should i send a v3 with that info included? or should i wait > for someone to do a more in depth review of the permissions? > (AFAICS nobody wrote anything about that yet) It's IMO fine to wait for another in-depth review (at least for the privs checking), if this version is already good to go it would be great if the maintainer pushing this would amend the numbers into the commit, but as long as b4 is used we at least got a easy to follow link to this thread, _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel