From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 4BE7B1FF140 for ; Fri, 13 Mar 2026 15:17:08 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 12D9945C0; Fri, 13 Mar 2026 15:17:13 +0100 (CET) Message-ID: <0caa5029-358b-49fa-ac73-8fc930b861a4@proxmox.com> Date: Fri, 13 Mar 2026 15:16:36 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH proxmox v5 08/13] s3-client: request counters: periodically persist counters to file To: Christian Ebner , pbs-devel@lists.proxmox.com References: <20260311130823.724888-1-c.ebner@proxmox.com> <20260311130823.724888-9-c.ebner@proxmox.com> Content-Language: en-US From: Hannes Laimer In-Reply-To: <20260311130823.724888-9-c.ebner@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1773411359289 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.991 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_SHORT 0.001 Use of a URL Shortener for very short URL RCVD_IN_MSPIKE_H2 0.001 Average reputation (+2) RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.408 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.819 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.903 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: LYTP7Y3AW7TUUJR7P732HKOIDGNDPQ7U X-Message-ID-Hash: LYTP7Y3AW7TUUJR7P732HKOIDGNDPQ7U X-MailFrom: h.laimer@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 2026-03-11 14:08, Christian Ebner wrote: > According to the mmap man page [0] shared memory mapped contents are > not guaranteed to be written back to the underlying file until > unmapped, unless the MAP_SYNC flag is used. This would however lead > to excessive I/O, writing counter states on each and every update. > > Therefore, periodically persist the counter state via asynchronous > msync calls. To reduce the number of such requests, do not perform > this unconditionally and for each mmapped counter individually, but > rather provide a global flusher which only does the flush if the > s3 client registered a callback function. Further, do not perform > the call for each counter update, but rather let the s3 client signal > when counter updates happened via an async channel. > > The task for flush request processing is instantiated and executed on > demand once callbacks are registered. > > [0] https://man7.org/linux/man-pages/man2/mmap.2.html > > Signed-off-by: Christian Ebner > --- [..] > @@ -455,6 +465,10 @@ impl S3Client { > .context("failed to account for upload traffic")?; > let _prev_uploaded = > counters.add_upload_traffic(transferred, Ordering::AcqRel); > + > + tokio::task::spawn_blocking(|| { > + let _ = SHARED_COUNTER_FLUSHER.read().unwrap().request_flush(); > + }); `request_flush()` does `try_send()`, so we don't need `spawn_blocking` here > } > return Ok(response?); > } [..]