From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id DCD2F1FF183 for ; Wed, 16 Jul 2025 14:09:47 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id B750DE3D1; Wed, 16 Jul 2025 14:10:51 +0200 (CEST) Message-ID: <0c74f47e-7290-4ffc-b848-7f834a9d1704@proxmox.com> Date: Wed, 16 Jul 2025 14:10:14 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Proxmox VE development discussion , Hannes Duerr References: <20250716114337.58432-1-h.duerr@proxmox.com> Content-Language: en-US From: Fiona Ebner In-Reply-To: <20250716114337.58432-1-h.duerr@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL -0.028 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_MSPIKE_H2 0.001 Average reputation (+2) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH pve-storage] RBDPlugin: add missing check for external ceph cluster X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" Thank you for the fix! Am 16.07.25 um 13:43 schrieb Hannes Duerr: > In this commit [0] the ceph config creation was packed into a new Please simply mention the commit ID (or better short ID + title) instead of adding a link to the git web interface. > function and checked whether the installation is an external Ceph > cluster or not. However, a check was forgotten in the RBDPlugin which we > are now adding. to avoid the "we", you could use e.g. "which is now added." > > Without this check a configuration in /etc/pve/priv/ceph/.conf is > created and pvestatd complains > > pvestatd[1144]: ignoring custom ceph config for storage 'pool', 'monhost' is not set (assuming pveceph managed cluster)! because the file /etc/pve/priv/ceph/pool.conf > > [0] https://git.proxmox.com/?p=pve-storage.git;a=commitdiff;h=7684225baccf0de07504ac21a25cbf576d60a766 > Please add: Fixes: 7684225 ("ceph/rbd: set 'keyring' in ceph configuration for externally managed RBD storages") > Signed-off-by: Hannes Duerr With improvements to the commit message and the style nits below addressed: Reviewed-by: Fiona Ebner > --- > src/PVE/Storage/RBDPlugin.pm | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/src/PVE/Storage/RBDPlugin.pm b/src/PVE/Storage/RBDPlugin.pm > index ce7db50..bf2e358 100644 > --- a/src/PVE/Storage/RBDPlugin.pm > +++ b/src/PVE/Storage/RBDPlugin.pm > @@ -457,8 +457,12 @@ sub options { > sub on_add_hook { > my ($class, $storeid, $scfg, %param) = @_; > > + my $pveceph_managed = !defined($scfg->{monhost}); > + > PVE::CephConfig::ceph_create_keyfile($scfg->{type}, $storeid, $param{keyring}); > - PVE::CephConfig::ceph_create_configuration($scfg->{type}, $storeid); > + Style nit: line above has trailing spaces > + PVE::CephConfig::ceph_create_configuration($scfg->{type}, $storeid) if (!$pveceph_managed); Stlye nit: superfluous parentheses in post-if > + > > return; > } _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel