applied: [PATCH] fix #8292: ui: node: StatusView: do not mutate the class-level items array

[Dominik Csapak <d.csapak@proxmox.com>]

applied, thanks!

Note that it seems your mail client mangled the mail and there were some
whitespace issues. I fixed that locally but please use
`git send-email` the next time, this would prevent such issues.

also, if sending a new version of the patch (even if it's just a resend)
you should begin a new thread, not answering on the same patch again

best regards
Dominik

On 11/10/26 3:36 PM, Raphaël Flores wrote:
>  From 6c7af488e31e006d500353134f21028e13345005 Mon Sep 17 00:00:00 2001
> From: =?UTF-8?q?Rapha=C3=ABl=20Flores?= <raphael.flores@inrae.fr>
> Date: Tue, 10 Nov 2026 15:24:47 +0100
> Subject: [PATCH] fix #8292: ui: node: StatusView: do not mutate the
>   class-level items array
> MIME-Version: 1.0
> Content-Type: text/plain; charset=UTF-8
> Content-Transfer-Encoding: 8bit
> 
> The repository status widget is appended to `items` in
> initComponent, but `items` is declared at class level, so every
> instance of PVE.node.StatusView receives the very same array. Each
> instantiation therefore left one more config object in that shared
> array: the k-th display of a node's Summary page constructed k
> pmxNodeInfoRepoStatus widgets instead of one, and all but one of
> them were never destroyed (they stay registered in
> Ext.ComponentManager, with no DOM node, and are not freed by the
> cycle collector).
> 
> The node view is rebuilt on every display of the summary panel, so
> the waste grows quadratically with navigation: 322 displays left
> 52 004 live widget instances and 208 322 ExtJS components behind,
> while the DOM stayed flat.
> 
> Build a per-instance array instead of pushing onto the shared one.
> 
> Signed-off-by: Raphaël Flores <raphael.flores@inrae.fr>
> ---
>   www/manager6/node/StatusView.js | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/www/manager6/node/StatusView.js b/www/manager6/node/ 
> StatusView.js
> index 0046f5d5..08d68a95 100644
> --- a/www/manager6/node/StatusView.js
> +++ b/www/manager6/node/StatusView.js
> @@ -157,7 +157,7 @@ Ext.define('PVE.node.StatusView', {
>               nodetab: 'aptrepositories',
>           });
> 
> -        me.items.push({
> +        me.items = me.items.concat({
>               xtype: 'pmxNodeInfoRepoStatus',
>               itemId: 'repositoryStatus',
>               product: 'Proxmox VE',