Re: [PATCH pve-storage v2 1/2] qemu-img: drop unused image resize timeout parameter

[Fiona Ebner <f.ebner@proxmox.com>]

Am 04.08.26 um 11:04 AM schrieb Jakob Klocker:
> qemu_img_resize is only ever called with a hardcoded 10 second timeout,
> so exposing it as a parameter serves no purpose.

The Storage::Common module is a bit special, because we want to allow
third-party plugins to re-use these methods too. There might already be
a caller from outside our code-base which does use the parameter, so I'd
rather keep it. The default value should still be adapted to fix the bug
of course and our callers can rely on that.

Of course, changing the default would also be an interface change, but I
would consider it okay. Dropping the parameter is also a bit of a
timebomb, becuase the next time we add a parameter, an existing caller
currently passing a value for timeout would suddenly pass a value for
the newly added parameter.

> 
> Signed-off-by: Jakob Klocker <j.klocker@proxmox.com>
> ---
>  src/PVE/Storage/Common.pm    | 8 ++++----
>  src/PVE/Storage/LVMPlugin.pm | 2 +-
>  src/PVE/Storage/Plugin.pm    | 2 +-
>  3 files changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/src/PVE/Storage/Common.pm b/src/PVE/Storage/Common.pm
> index 3932aee..725f623 100644
> --- a/src/PVE/Storage/Common.pm
> +++ b/src/PVE/Storage/Common.pm
> @@ -259,16 +259,16 @@ sub qemu_img_measure {
>  
>  =head3 qemu_img_resize
>  
> -    qemu_img_resize($path, $format, $size, $preallocation, $timeout)
> +    qemu_img_resize($path, $format, $size, $preallocation)