From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <t.lamprecht@proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 1845360C89 for <pve-devel@lists.proxmox.com>; Fri, 27 Nov 2020 10:55:41 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 0C0991A42F for <pve-devel@lists.proxmox.com>; Fri, 27 Nov 2020 10:55:41 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 817E91A41F for <pve-devel@lists.proxmox.com>; Fri, 27 Nov 2020 10:55:39 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 42C6B444DA for <pve-devel@lists.proxmox.com>; Fri, 27 Nov 2020 10:55:39 +0100 (CET) To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>, Fabian Ebner <f.ebner@proxmox.com> References: <20201127093544.17667-1-f.ebner@proxmox.com> From: Thomas Lamprecht <t.lamprecht@proxmox.com> Message-ID: <0ac66c58-ca83-c0ee-325e-e0dbde99f1e7@proxmox.com> Date: Fri, 27 Nov 2020 10:55:36 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:83.0) Gecko/20100101 Thunderbird/83.0 MIME-Version: 1.0 In-Reply-To: <20201127093544.17667-1-f.ebner@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.078 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [cifsplugin.pm, rbdplugin.pm, zfspoolplugin.pm, cephfsplugin.pm, proxmox.com, lvmplugin.pm, pbsplugin.pm] Subject: [pve-devel] applied: [PATCH storage] plugin: hooks: add explicit returns X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> X-List-Received-Date: Fri, 27 Nov 2020 09:55:41 -0000 On 27.11.20 10:35, Fabian Ebner wrote: > to avoid returning something unexpected. Finish what > afeda182566292be15413d9b874720876eac14c9 already started for all the other > plugins. At least for ZFS's on_add_hook this is necessary (adding a ZFS storage > currently fails as reported here [0]), but it cannot hurt > in the other places either as the only hooks we expect to return something > currently are PBS's on_add_hook and on_update_hook. > > [0]: https://forum.proxmox.com/threads/gui-add-zfs-storage-verification-failed-400-config-type-check-object-failed.79734/ > > Signed-off-by: Fabian Ebner <f.ebner@proxmox.com> > --- > PVE/Storage/CIFSPlugin.pm | 6 ++++++ > PVE/Storage/CephFSPlugin.pm | 4 ++++ > PVE/Storage/LVMPlugin.pm | 2 ++ > PVE/Storage/PBSPlugin.pm | 2 ++ > PVE/Storage/RBDPlugin.pm | 4 ++++ > PVE/Storage/ZFSPoolPlugin.pm | 2 ++ > 6 files changed, 20 insertions(+) > > applied, thanks!