Re: [PATCH storage 1/1] cifs: match smbversion description with docs

[Fiona Ebner <f.ebner@proxmox.com>]

The circular reference in the commit titles are not telling much. Please
use titles which better describe the changes.

Am 26.02.26 um 3:43 PM schrieb Maximiliano Sandoval:
> Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
> ---
>  src/PVE/Storage/CIFSPlugin.pm | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/src/PVE/Storage/CIFSPlugin.pm b/src/PVE/Storage/CIFSPlugin.pm
> index 54f0f4e..665ce1f 100644
> --- a/src/PVE/Storage/CIFSPlugin.pm
> +++ b/src/PVE/Storage/CIFSPlugin.pm
> @@ -147,9 +147,10 @@ sub properties {
>              maxLength => 256,
>          },
>          smbversion => {
> -            description =>
> -                "SMB protocol version. 'default' if not set, negotiates the highest SMB2+"
> -                . " version supported by both the client and server.",
> +            description => "SMB protocol version.",
> +            verbose_description => "SMB protocol version. When set to `default` or when unset,"
> +                . " negotiates the highest SMB2+ version supported by both the client and server."
> +                . " SMB1 is not supported due to security issues.",

While splitting description and verbose_description is sensible in
general, in case of 'man pvesm', this means that the verbose information
is not shown there anymore, which is not nice. So I held off from
applying this one. We should either make sure the verbose information is
shown there too (better solution) or just adapt the description.

>              type => 'string',
>              default => 'default',
>              enum => ['default', '2.0', '2.1', '3', '3.0', '3.11'],