From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 114C31FF136 for ; Mon, 09 Mar 2026 10:44:29 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 435921E17E; Mon, 9 Mar 2026 10:44:21 +0100 (CET) Message-ID: <0908109e-62d7-4979-9909-182bc16752cb@proxmox.com> Date: Mon, 9 Mar 2026 10:44:16 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta Subject: Re: applied: [PATCH datacenter-manager/proxmox v4 0/7] fix #6914: add option to remove already existing token To: Thomas Lamprecht , pdm-devel@lists.proxmox.com, Shan Shaji References: <20260218164135.413762-1-s.shaji@proxmox.com> <177299416482.2028613.14201364803068895391.b4-ty@proxmox.com> Content-Language: en-US From: Dominik Csapak In-Reply-To: <177299416482.2028613.14201364803068895391.b4-ty@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1773049425209 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.087 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_LOTSOFHASH 0.25 Emails with lots of hash-like gibberish RCVD_IN_MSPIKE_H2 0.001 Average reputation (+2) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: BZZ6RFJK37J5V4DT3Y7QHQF5H2JQNGU4 X-Message-ID-Hash: BZZ6RFJK37J5V4DT3Y7QHQF5H2JQNGU4 X-MailFrom: d.csapak@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: it seems the 2/6 commit is missing here, meaning the ui now uses an option on delete that is not there in the api, was this intentional? (i.e. is there something wrong with the patch from your side?) On 3/8/26 7:23 PM, Thomas Lamprecht wrote: > On Wed, 18 Feb 2026 17:41:28 +0100, Shan Shaji wrote: >> If a user removed a remote without deleting its associated token, >> PDM would not allow re-adding the same remote unless the token >> was changed. To fix this, support for optionally deleting the token >> on the remote has been added. >> >> new changes: >> - use ConfirmDialog widget for creating the confirmation dialog. >> - add token deletion as opt-out feature. >> >> [...] > > Applied, thanks! > > [1/6] server: pbs-client: add method to delete token from remote > commit: cef803fde6069c32cb79182336a7f8c62f31342b > [1/1] pve-api-types: generate missing `delete_token` method > (no commit info) > [3/6] pdm-client: accept `delete-token` argument for deleting api token > commit: fa87d7c7b40e89cb528c78ecac217cd31d713061 > [4/6] fix #6914: cli-client: add option to delete token from remote > commit: 8249b9a40b0b47f600edc8f552fedd19ac12b4cf > [5/6] fix #6914: ui: add remove remote dialog with optional token deletion > commit: 4ecebbcbdc6c232c8dcc5d45e83bd39d81480991 > [6/6] fix #6914: cli-admin: add option to delete token from remote > commit: 461f3331545c4f5c4d21a05f64c8f374fa06ad5e > > > >