From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 5D9AC1FF16F for ; Tue, 8 Jul 2025 12:18:27 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id C673A13ACC; Tue, 8 Jul 2025 12:19:11 +0200 (CEST) Message-ID: <08923d45-cc6c-44aa-87b7-3920594b30fe@proxmox.com> Date: Tue, 8 Jul 2025 12:18:38 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Thomas Lamprecht , Proxmox VE development discussion References: <20250707080352.58713-1-f.weber@proxmox.com> <20250707080352.58713-5-f.weber@proxmox.com> <3c2b9965-bbdb-47d7-be49-6e6a9623d750@proxmox.com> Content-Language: en-US From: Friedrich Weber In-Reply-To: <3c2b9965-bbdb-47d7-be49-6e6a9623d750@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.010 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [pve8to9.pm] Subject: Re: [pve-devel] [PATCH pve-manager v4 2/3] pve8to9: move checklist to dedicated subcommand X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" On 07/07/2025 20:46, Thomas Lamprecht wrote: > Am 07.07.25 um 10:03 schrieb Friedrich Weber: >> This allows to introduce other subcommands, e.g. for manual actions >> rqeuired before the upgrade. >> >> Signed-off-by: Friedrich Weber >> --- >> >> Notes: >> changes since v3: >> - rephrase commit message >> >> new in v3 >> >> PVE/CLI/pve8to9.pm | 4 +++- >> bin/Makefile | 2 +- >> 2 files changed, 4 insertions(+), 2 deletions(-) >> >> diff --git a/PVE/CLI/pve8to9.pm b/PVE/CLI/pve8to9.pm >> index 45692748..c3fb0b0b 100644 >> --- a/PVE/CLI/pve8to9.pm >> +++ b/PVE/CLI/pve8to9.pm >> @@ -1595,6 +1595,8 @@ __PACKAGE__->register_method({ >> }, >> }); >> >> -our $cmddef = [__PACKAGE__, 'checklist', [], {}]; >> +our $cmddef = { >> + checklist => [__PACKAGE__, 'checklist', []], > > we nowadays normally use minus to separate command words, but it > probably would be fine to just drop the "list" part. > > I'd also strongly prefer making this the default command, if none is > supplied. > Thanks for looking into this! But since I'm going to move `updatelvm` to its own script anyway (see the reply to the cover letter), I'll just drop this patch and keep $cmddef as it is in v5. >> +}; >> >> 1; >> diff --git a/bin/Makefile b/bin/Makefile >> index caed0af4..23635a16 100644 >> --- a/bin/Makefile >> +++ b/bin/Makefile >> @@ -73,7 +73,7 @@ pve8to9.1: >> before, and during the upgrade of a Proxmox VE system\n" >> $@.tmp >> printf "Any failure must be addressed before the upgrade, and any warning must be addressed, \ >> or at least carefully evaluated, if a false-positive is suspected\n" >> $@.tmp >> - printf ".SH SYNOPSIS\npve8to9 [--full]\n" >> $@.tmp >> + printf ".SH SYNOPSIS\npve8to9 checklist [--full]\n" >> $@.tmp >> mv $@.tmp $@ >> >> > _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel