From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id 9562E1FF138 for ; Mon, 20 Jul 2026 10:26:41 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 11F64214DF; Mon, 20 Jul 2026 10:26:40 +0200 (CEST) Message-ID: <0835083b-0edc-4506-8d93-d82bf960256a@proxmox.com> Date: Mon, 20 Jul 2026 10:26:35 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: David Riley Subject: Re: [PATCH qemu-server v2 10/10] fix #7294: helpers: use cluster-wide version helper To: Daniel Kral , pve-devel@lists.proxmox.com References: <20260626131035.112374-1-d.riley@proxmox.com> <20260626131035.112374-11-d.riley@proxmox.com> Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1784535971804 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.111 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_LOW -0.7 Sender listed at https://www.dnswl.org/, low trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: Z2ZT4KVOLWCIR6LRFZCG6EHMAH34K6RE X-Message-ID-Hash: Z2ZT4KVOLWCIR6LRFZCG6EHMAH34K6RE X-MailFrom: d.riley@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 7/6/26 3:21 PM, Daniel Kral wrote: > On Fri Jun 26, 2026 at 3:10 PM CEST, David Riley wrote: >> Drop the local `version_cmp` and `pvecfg_min_version` implementations >> and update call sites to use the centralized tools module in >> pve-common. >> >> Link:https://bugzilla.proxmox.com/show_bug.cgi?id=7294 >> Signed-off-by: David Riley > The patch subject here (and in some other patches) shouldn't contain the > 'fix #7294' as it isn't directly related to the bugzilla but only some > preparation. True, I'll remove the #7294 from the commits that do not directly relate to the bugzilla entry. Thanks for your feedback on this patch series! > Otherwise consider as: > > Reviewed-by: Daniel Kral > > > >