Re: [PATCH v4 0/5] client: repository: add individual component parameters

[Christian Ebner <c.ebner@proxmox.com>]

On 4/10/26 5:43 PM, Thomas Lamprecht wrote:
> Follow-up to [v3], reworked based on Wolfgang's and Christian's review
> feedback - thx!
> 
> The compact repository URL format ([[auth-id@]server[:port]:]datastore)
> can be cumbersome to work with when changing a single aspect of the
> connection or when using API tokens. This series adds --server, --port,
> --datastore, --auth-id, and --ns as separate CLI parameters alongside
> the existing compound --repository URL.
> 
> Changes since [v3]:
> - Deduplicated mutual-exclusion check into check_mutual_exclusion()
> - Used AllOfSchema for mount.rs raw ApiMethod definitions
> - Commands where --ns is irrelevant (login, logout, version, status, GC,
>    benchmark, task) now use BackupRepositoryArgs only
> - Moved optional_ns_param() to pbs-client tools as shared helper
> - Fixed change_backup_owner not stripping atom fields before forwarding
> - Small nits (anyhow::bail! -> bail!, private ENV_VAR_PBS_NAMESPACE)
> 
> Changes since [v2]:
> - Deduplicated param resolution cascade into shared helper
> - Split into BackupRepositoryArgs and BackupTargetArgs (repo + ns)
> 
> Changes since [v1]:
> - Split single commit into five
> - CLI atoms now merge with PBS_* env vars per-field (CLI wins)
> - Fixed mutual-exclusion error swallowing and duplicate ns property
> - PBS_NAMESPACE works uniformly across all three client binaries
> 
> [v3]: https://lore.proxmox.com/pbs-devel/20260401225305.4069441-1-t.lamprecht@proxmox.com/
> [v2]: https://lore.proxmox.com/pbs-devel/20260330182352.2346420-1-t.lamprecht@proxmox.com/
> [v1]: https://lore.proxmox.com/pbs-devel/20260323211400.2661765-1-t.lamprecht@proxmox.com/


Reviewed-by: Christian Ebner <c.ebner@proxmox.com>
Tested-by: Christian Ebner <c.ebner@proxmox.com>