From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <t.lamprecht@proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by lists.proxmox.com (Postfix) with ESMTPS id 215F36B74D
 for <pve-devel@lists.proxmox.com>; Tue, 26 Jan 2021 18:55:52 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
 by firstgate.proxmox.com (Proxmox) with ESMTP id 1816A1B7E0
 for <pve-devel@lists.proxmox.com>; Tue, 26 Jan 2021 18:55:22 +0100 (CET)
Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com
 [212.186.127.180])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by firstgate.proxmox.com (Proxmox) with ESMTPS id A40831B7D6
 for <pve-devel@lists.proxmox.com>; Tue, 26 Jan 2021 18:55:21 +0100 (CET)
Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])
 by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 6F53C46117
 for <pve-devel@lists.proxmox.com>; Tue, 26 Jan 2021 18:55:21 +0100 (CET)
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
 =?UTF-8?Q?Dominic_J=c3=a4ger?= <d.jaeger@proxmox.com>
References: <20201127110812.102886-1-d.jaeger@proxmox.com>
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
Message-ID: <07c53d23-008e-ba60-a974-1fc25b76e9b9@proxmox.com>
Date: Tue, 26 Jan 2021 18:55:20 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:85.0) Gecko/20100101
 Thunderbird/85.0
MIME-Version: 1.0
In-Reply-To: <20201127110812.102886-1-d.jaeger@proxmox.com>
Content-Type: text/plain; charset=UTF-8
Content-Language: en-US
Content-Transfer-Encoding: quoted-printable
X-SPAM-LEVEL: Spam detection results:  0
 AWL -0.065 Adjusted score from AWL reputation of From: address
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 RCVD_IN_DNSWL_MED        -2.3 Sender listed at https://www.dnswl.org/,
 medium trust
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_PASS               -0.001 SPF: sender matches SPF record
Subject: [pve-devel] applied: [PATCH widget-toolkit] input panel: Add
 drawing of layout
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
X-List-Received-Date: Tue, 26 Jan 2021 17:55:52 -0000

On 27.11.20 12:08, Dominic J=C3=A4ger wrote:
> The drawing makes clear in a few seconds:
>  - what columnT and columnB stand for
>  - what additional containers and panels are created
>  - to which of those the elements of column1, column2... go to
>=20
> When you're in the JS debugger and lost overview of where in this
> element hierarchy you are, you can quickly check xtype + layout. Then
> consulting this drawing solves the mistery.
>=20
> Signed-off-by: Dominic J=C3=A4ger <d.jaeger@proxmox.com>
> ---
> IMO it's not that easy/quick to see where everything goes to.
> initComponent is not that short. I actually drew the layout on paper
> to keep an overview while reading it.
>=20
> There was a drawing already in the commit message of
> 455f5fe input panel: support convenience top column
> so I assumed I'm not the only one who finds such a drawing useful and
> it is easier to find here than in the commit message.
> =20
>  src/panel/InputPanel.js | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
>=20
>

applied, thanks!