From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <n.ullreich@proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 3D5BCBAF8 for <pve-devel@lists.proxmox.com>; Mon, 3 Jul 2023 14:08:33 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 26A4D1D271 for <pve-devel@lists.proxmox.com>; Mon, 3 Jul 2023 14:08:33 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for <pve-devel@lists.proxmox.com>; Mon, 3 Jul 2023 14:08:32 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 6EA1C43829 for <pve-devel@lists.proxmox.com>; Mon, 3 Jul 2023 14:08:32 +0200 (CEST) Message-ID: <07b5381e-91e6-88a6-fee5-458241512149@proxmox.com> Date: Mon, 3 Jul 2023 14:08:31 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Content-Language: en-US To: pve-devel@lists.proxmox.com References: <20230616095410.33426-1-n.ullreich@proxmox.com> From: Noel Ullreich <n.ullreich@proxmox.com> In-Reply-To: <20230616095410.33426-1-n.ullreich@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.110 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.09 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pve-devel] [PATCH pve-manager 0/2] ui: fix #3760: change units of ram/swap X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> X-List-Received-Date: Mon, 03 Jul 2023 12:08:33 -0000 Ping. Still applies With me leaving at the end of the month, I want to make sure there is plenty of time for my outstanding patches to be reviewed, updated, and applied. On 16-06-2023 11:54, Noel Ullreich wrote: > Up until now, ram, balloonsize and swap were set in MiB, meaning if you wanted to > create or change a VMs/CTs memory, you would first have to do the math to > convert from GiB to MiB. > This patch adds a dropdown-menu of units, MiB, GiB, and TiB, (although > PiB could easily be added in the future) for ram and swap. > A future patch in line with this could add units in the API, allowing for > improved usability from the commandline (e.g. `qm create <id> --memory 2GiB`). > > having `scalingFactor` list in MemoryEdit and Resource Edits might not > be the most elegant solution, the other option was sticking them in > `proxmox-widget-toolkit/src/Utils.js` or using the units from there. > However, if we want to use the units from there, we need to scale them > and trim the unneeded units. So I thought the least invasive solution > was to put the `scalingFactor` right in the Files. > > Noel Ullreich (2): > ui: fix #3760: change unit of memory of a VM > ui: fix: change units of memory/swap for containers > > www/manager6/lxc/ResourceEdit.js | 136 ++++++++++++++++--- > www/manager6/qemu/MemoryEdit.js | 221 +++++++++++++++++++++++-------- > 2 files changed, 285 insertions(+), 72 deletions(-) >