From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <pve-devel-bounces@lists.proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id C79B41FF38F for <inbox@lore.proxmox.com>; Tue, 21 May 2024 16:06:46 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 0F8321AE2D; Tue, 21 May 2024 16:07:03 +0200 (CEST) Message-ID: <05fa1a88-62c1-4ee0-a758-c1c57d5632b0@proxmox.com> Date: Tue, 21 May 2024 16:06:23 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>, Stoiko Ivanov <s.ivanov@proxmox.com> References: <20240507150210.1391522-1-s.ivanov@proxmox.com> Content-Language: en-GB, de-AT From: Thomas Lamprecht <t.lamprecht@proxmox.com> Autocrypt: addr=t.lamprecht@proxmox.com; keydata= xsFNBFsLjcYBEACsaQP6uTtw/xHTUCKF4VD4/Wfg7gGn47+OfCKJQAD+Oyb3HSBkjclopC5J uXsB1vVOfqVYE6PO8FlD2L5nxgT3SWkc6Ka634G/yGDU3ZC3C/7NcDVKhSBI5E0ww4Qj8s9w OQRloemb5LOBkJNEUshkWRTHHOmk6QqFB/qBPW2COpAx6oyxVUvBCgm/1S0dAZ9gfkvpqFSD 90B5j3bL6i9FIv3YGUCgz6Ue3f7u+HsEAew6TMtlt90XV3vT4M2IOuECG/pXwTy7NtmHaBQ7 UJBcwSOpDEweNob50+9B4KbnVn1ydx+K6UnEcGDvUWBkREccvuExvupYYYQ5dIhRFf3fkS4+ wMlyAFh8PQUgauod+vqs45FJaSgTqIALSBsEHKEs6IoTXtnnpbhu3p6XBin4hunwoBFiyYt6 YHLAM1yLfCyX510DFzX/Ze2hLqatqzY5Wa7NIXqYYelz7tXiuCLHP84+sV6JtEkeSUCuOiUY virj6nT/nJK8m0BzdR6FgGtNxp7RVXFRz/+mwijJVLpFsyG1i0Hmv2zTn3h2nyGK/I6yhFNt dX69y5hbo6LAsRjLUvZeHXpTU4TrpN/WiCjJblbj5um5eEr4yhcwhVmG102puTtuCECsDucZ jpKpUqzXlpLbzG/dp9dXFH3MivvfuaHrg3MtjXY1i+/Oxyp5iwARAQABzTNUaG9tYXMgTGFt cHJlY2h0IChBdXRoLTQpIDx0LmxhbXByZWNodEBwcm94bW94LmNvbT7CwY4EEwEIADgWIQQO R4qbEl/pah9K6VrTZCM6gDZWBgUCWwuNxgIbAwULCQgHAgYVCAkKCwIEFgIDAQIeAQIXgAAK CRDTZCM6gDZWBm/jD/4+6JB2s67eaqoP6x9VGaXNGJPCscwzLuxDTCG90G9FYu29VcXtubH/ bPwsyBbNUQpqTm/s4XboU2qpS5ykCuTjqavrcP33tdkYfGcItj2xMipJ1i3TWvpikQVsX42R G64wovLs/dvpTYphRZkg5DwhgTmy3mRkmofFCTa+//MOcNOORltemp984tWjpR3bUJETNWpF sKGZHa3N4kCNxb7A+VMsJZ/1gN3jbQbQG7GkJtnHlWkw9rKCYqBtWrnrHa4UAvSa9M/XCIAB FThFGqZI1ojdVlv5gd6b/nWxfOPrLlSxbUo5FZ1i/ycj7/24nznW1V4ykG9iUld4uYUY86bB UGSjew1KYp9FmvKiwEoB+zxNnuEQfS7/Bj1X9nxizgweiHIyFsRqgogTvLh403QMSGNSoArk tqkorf1U+VhEncIn4H3KksJF0njZKfilrieOO7Vuot1xKr9QnYrZzJ7m7ZxJ/JfKGaRHXkE1 feMmrvZD1AtdUATZkoeQtTOpMu4r6IQRfSdwm/CkppZXfDe50DJxAMDWwfK2rr2bVkNg/yZI tKLBS0YgRTIynkvv0h8d9dIjiicw3RMeYXyqOnSWVva2r+tl+JBaenr8YTQw0zARrhC0mttu cIZGnVEvQuDwib57QLqMjQaC1gazKHvhA15H5MNxUhwm229UmdH3KM7BTQRbC43GARAAyTkR D6KRJ9Xa2fVMh+6f186q0M3ni+5tsaVhUiykxjsPgkuWXWW9MbLpYXkzX6h/RIEKlo2BGA95 QwG5+Ya2Bo3g7FGJHAkXY6loq7DgMp5/TVQ8phsSv3WxPTJLCBq6vNBamp5hda4cfXFUymsy HsJy4dtgkrPQ/bnsdFDCRUuhJHopnAzKHN8APXpKU6xV5e3GE4LwFsDhNHfH/m9+2yO/trcD txSFpyftbK2gaMERHgA8SKkzRhiwRTt9w5idOfpJVkYRsgvuSGZ0pcD4kLCOIFrer5xXudk6 NgJc36XkFRMnwqrL/bB4k6Pi2u5leyqcXSLyBgeHsZJxg6Lcr2LZ35+8RQGPOw9C0ItmRjtY ZpGKPlSxjxA1WHT2YlF9CEt3nx7c4C3thHHtqBra6BGPyW8rvtq4zRqZRLPmZ0kt/kiMPhTM 8wZAlObbATVrUMcZ/uNjRv2vU9O5aTAD9E5r1B0dlqKgxyoImUWB0JgpILADaT3VybDd3C8X s6Jt8MytUP+1cEWt9VKo4vY4Jh5vwrJUDLJvzpN+TsYCZPNVj18+jf9uGRaoK6W++DdMAr5l gQiwsNgf9372dbMI7pt2gnT5/YdG+ZHnIIlXC6OUonA1Ro/Itg90Q7iQySnKKkqqnWVc+qO9 GJbzcGykxD6EQtCSlurt3/5IXTA7t6sAEQEAAcLBdgQYAQgAIBYhBA5HipsSX+lqH0rpWtNk IzqANlYGBQJbC43GAhsMAAoJENNkIzqANlYGD1sP/ikKgHgcspEKqDED9gQrTBvipH85si0j /Jwu/tBtnYjLgKLh2cjv1JkgYYjb3DyZa1pLsIv6rGnPX9bH9IN03nqirC/Q1Y1lnbNTynPk IflgvsJjoTNZjgu1wUdQlBgL/JhUp1sIYID11jZphgzfDgp/E6ve/8xE2HMAnf4zAfJaKgD0 F+fL1DlcdYUditAiYEuN40Ns/abKs8I1MYx7Yglu3RzJfBzV4t86DAR+OvuF9v188WrFwXCS RSf4DmJ8tntyNej+DVGUnmKHupLQJO7uqCKB/1HLlMKc5G3GLoGqJliHjUHUAXNzinlpE2Vj C78pxpwxRNg2ilE3AhPoAXrY5qED5PLE9sLnmQ9AzRcMMJUXjTNEDxEYbF55SdGBHHOAcZtA kEQKub86e+GHA+Z8oXQSGeSGOkqHi7zfgW1UexddTvaRwE6AyZ6FxTApm8wq8NT2cryWPWTF BDSGB3ujWHMM8ERRYJPcBSjTvt0GcEqnd+OSGgxTkGOdufn51oz82zfpVo1t+J/FNz6MRMcg 8nEC+uKvgzH1nujxJ5pRCBOquFZaGn/p71Yr0oVitkttLKblFsqwa+10Lt6HBxm+2+VLp4Ja 0WZNncZciz3V3cuArpan/ZhhyiWYV5FD0pOXPCJIx7WS9PTtxiv0AOS4ScWEUmBxyhFeOpYa DrEx In-Reply-To: <20240507150210.1391522-1-s.ivanov@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL -0.453 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_NUMSUBJECT 0.5 Subject ends in numbers excluding current years POISEN_SPAM_PILL 0.1 Meta: its spam POISEN_SPAM_PILL_1 0.1 random spam to be learned in bayes POISEN_SPAM_PILL_3 0.1 random spam to be learned in bayes SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] applied-series: [PATCH zfsonlinux v2 0/2] Update to ZFS 2.2.4 X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com> Am 07/05/2024 um 17:02 schrieb Stoiko Ivanov: > v1->v2: > Patch 2/2 (adaptation of arc_summary/arcstat patch) modified: > * right after sending the v1 I saw a report where pinning kernel 6.2 (thus > ZFS 2.1) leads to a similar traceback - which I seem to have overlooked > when packaging 2.2.0 ... > adapted the patch by booting a VM with kernel 6.2 and the current > userspace and running arc_summary /arcstat -a until no traceback was > displayed with a single-disk pool. > > original cover-letter for v1: > This patchset updates ZFS to the recently released 2.2.4 > > We had about half of the patches already in 2.2.3-2, due to the needed > support for kernel 6.8. > > Compared to the last 2.2 point releases this one compares quite a few > potential performance improvments: > * for ZVOL workloads (relevant for qemu guests) multiple taskq were > introduced [1] - this change is active by default (can be put back to > the old behavior with explicitly setting `zvol_num_taskqs=1` > * the interface for ZFS submitting operations to the kernel's block layer > was augmented to better deal with split-pages [2] - which should also > improve performance, and prevent unaligned writes which are rejected by > e.g. the SCSI subsystem. - The default remains with the current code > (`zfs_vdev_disk_classic=0` turns on the 'new' behavior...) > * Speculative prefetching was improved [3], which introduced not kstats, > which are reported by`arc_summary` and `arcstat`, as before with the > MRU/MFU additions there was not guard for running the new user-space > with an old kernel resulting in Python exceptions of both tools. > I adapted the patch where Thomas fixed that back in the 2.1 release > times. - sending as separate patch for easier review - and I hope it's > ok that I dropped the S-o-b tag (as it's changed code) - glad to resend > it, if this should be adapted. > > Minimally tested on 2 VMs (the arcstat/arc_summary changes by running with > an old kernel and new user-space) > > > [0] https://github.com/openzfs/zfs/releases/tag/zfs-2.2.4 > [1] https://github.com/openzfs/zfs/pull/15992 > [2] https://github.com/openzfs/zfs/pull/15588 > [3] https://github.com/openzfs/zfs/pull/16022 > > Stoiko Ivanov (2): > update zfs submodule to 2.2.4 and refresh patches > update arc_summary arcstat patch with new introduced values > > ...md-unit-for-importing-specific-pools.patch | 4 +- > ...-move-manpage-arcstat-1-to-arcstat-8.patch | 2 +- > ...-guard-access-to-freshly-introduced-.patch | 438 ++++++++++++ > ...-guard-access-to-l2arc-MFU-MRU-stats.patch | 113 --- > ...hten-bounds-for-noalloc-stat-availab.patch | 4 +- > ...rectly-handle-partition-16-and-later.patch | 52 -- > ...-use-splice_copy_file_range-for-fall.patch | 135 ---- > .../0014-linux-5.4-compat-page_size.patch | 121 ---- > .../patches/0015-abd-add-page-iterator.patch | 334 --------- > ...-existing-functions-to-vdev_classic_.patch | 349 --------- > ...v_disk-reorganise-vdev_disk_io_start.patch | 111 --- > ...-read-write-IO-function-configurable.patch | 69 -- > ...e-BIO-filling-machinery-to-avoid-spl.patch | 671 ------------------ > ...dule-parameter-to-select-BIO-submiss.patch | 104 --- > ...se-bio_chain-to-submit-multiple-BIOs.patch | 363 ---------- > ...on-t-use-compound-heads-on-Linux-4.5.patch | 96 --- > ...ault-to-classic-submission-for-2.2.x.patch | 90 --- > ...ion-caused-by-mmap-flushing-problems.patch | 104 --- > ...touch-vbio-after-its-handed-off-to-t.patch | 57 -- > debian/patches/series | 16 +- > upstream | 2 +- > 21 files changed, 445 insertions(+), 2790 deletions(-) > create mode 100644 debian/patches/0009-arc-stat-summary-guard-access-to-freshly-introduced-.patch > delete mode 100644 debian/patches/0009-arc-stat-summary-guard-access-to-l2arc-MFU-MRU-stats.patch > delete mode 100644 debian/patches/0012-udev-correctly-handle-partition-16-and-later.patch > delete mode 100644 debian/patches/0013-Linux-6.8-compat-use-splice_copy_file_range-for-fall.patch > delete mode 100644 debian/patches/0014-linux-5.4-compat-page_size.patch > delete mode 100644 debian/patches/0015-abd-add-page-iterator.patch > delete mode 100644 debian/patches/0016-vdev_disk-rename-existing-functions-to-vdev_classic_.patch > delete mode 100644 debian/patches/0017-vdev_disk-reorganise-vdev_disk_io_start.patch > delete mode 100644 debian/patches/0018-vdev_disk-make-read-write-IO-function-configurable.patch > delete mode 100644 debian/patches/0019-vdev_disk-rewrite-BIO-filling-machinery-to-avoid-spl.patch > delete mode 100644 debian/patches/0020-vdev_disk-add-module-parameter-to-select-BIO-submiss.patch > delete mode 100644 debian/patches/0021-vdev_disk-use-bio_chain-to-submit-multiple-BIOs.patch > delete mode 100644 debian/patches/0022-abd_iter_page-don-t-use-compound-heads-on-Linux-4.5.patch > delete mode 100644 debian/patches/0023-vdev_disk-default-to-classic-submission-for-2.2.x.patch > delete mode 100644 debian/patches/0024-Fix-corruption-caused-by-mmap-flushing-problems.patch > delete mode 100644 debian/patches/0025-vdev_disk-don-t-touch-vbio-after-its-handed-off-to-t.patch > applied series with Max's T-b and R-b, where applicable, thanks! Did not yet make a version bump or updated the kernel repo though, I'd wait for a new kernel build to do that. _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel