From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <t.lamprecht@proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id D1EA389ADE for <pve-devel@lists.proxmox.com>; Tue, 18 Oct 2022 08:39:19 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id B1F2725754 for <pve-devel@lists.proxmox.com>; Tue, 18 Oct 2022 08:39:19 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for <pve-devel@lists.proxmox.com>; Tue, 18 Oct 2022 08:39:19 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id D5C36445A5; Tue, 18 Oct 2022 08:39:18 +0200 (CEST) Message-ID: <04af6869-aaef-82fe-c225-36aee0b1179f@proxmox.com> Date: Tue, 18 Oct 2022 08:39:18 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:106.0) Gecko/20100101 Thunderbird/106.0 To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>, "DERUMIER, Alexandre" <Alexandre.DERUMIER@groupe-cyllene.com> References: <20220928125059.1139296-1-f.gruenbichler@proxmox.com> <20220928125059.1139296-13-f.gruenbichler@proxmox.com> <f5d43fee-801f-61e1-867c-05157732a7af@groupe-cyllene.com> Content-Language: en-GB From: Thomas Lamprecht <t.lamprecht@proxmox.com> In-Reply-To: <f5d43fee-801f-61e1-867c-05157732a7af@groupe-cyllene.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.034 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.001 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH v6 qemu-server 6/6] qm: add remote-migrate command X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> X-List-Received-Date: Tue, 18 Oct 2022 06:39:19 -0000 Hi, Am 17/10/2022 um 16:40 schrieb DERUMIER, Alexandre: >> an example invocation: >> >> $ qm remote-migrate 1234 4321 > 'host=123.123.123.123,apitoken=pveapitoken=user@pve!incoming=aaaaaaaa-bbbb-cccc-dddd-eeeeeeeeeeee,fingerprint=aa:bb:cc:dd:ee:ff:aa:bb:cc:dd:ee:ff:aa:bb:cc:dd:ee:ff:aa:bb:cc:dd:ee:ff:aa:bb:cc:dd:ee:ff:aa:bb' > --target-bridge vmbr0 --target-storage zfs-a:rbd-b,nfs-c:dir-d,zfs-e > --online > > > Maybe it could be better (optionnaly) to store the long > > "'host=123.123.123.123,apitoken=pveapitoken=user@pve!incoming=aaaaaaaa-bbbb-cccc-dddd-eeeeeeeeeeee,fingerprint=aa:bb:cc:dd:ee:ff:aa:bb:cc:dd:ee:ff:aa:bb:cc:dd:ee:ff:aa:bb:cc:dd:ee:ff:aa:bb:cc:dd:ee:ff:aa:bb' > " > > in a config file in /etc/pve/priv/<targethost>.conf ? > > > Like this, this should avoid to have the api token in the bash history. > > maybe something like: > > qm remote-migration 1234 4321 <targethost> .... > > ? We plan to have such functionality in the datacenter manager, as that should provide a better way to manage such remotes and interfacing, in PVE it'd be bolted on and would require the need to manage this on every host/cluster separately. IOW. this is rather the lower level interface. It may still make sense to allow passing a remote via more private channels, like the environment or `stdin`, wouldn't be hard to do, just mark the target-endpoint as optional and fallback to $ENV{'..'} and maybe a json string from STDIN - which an admin that wants to use this lower level part directly can then even use with a file config served via bash input redicrection `qm remote-migration 1234 4321 </etc/pve/priv/target-host.json`