From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <t.lamprecht@proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
 (No client certificate requested)
 by lists.proxmox.com (Postfix) with ESMTPS id 6BAB9792BE
 for <pve-devel@lists.proxmox.com>; Tue,  4 May 2021 09:12:03 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
 by firstgate.proxmox.com (Proxmox) with ESMTP id 5FCC723D89
 for <pve-devel@lists.proxmox.com>; Tue,  4 May 2021 09:12:03 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com
 [94.136.29.106])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
 (No client certificate requested)
 by firstgate.proxmox.com (Proxmox) with ESMTPS id B74B023D7B
 for <pve-devel@lists.proxmox.com>; Tue,  4 May 2021 09:12:01 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])
 by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 8BE7042112;
 Tue,  4 May 2021 09:12:01 +0200 (CEST)
Message-ID: <01e6faf2-cb15-d021-bf50-f5606ba1909d@proxmox.com>
Date: Tue, 4 May 2021 09:12:00 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:89.0) Gecko/20100101
 Thunderbird/89.0
Content-Language: en-US
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
 =?UTF-8?Q?Daniel_Ko=c4=87?= <daniel@xn--ko-wla.pl>
References: <b8c79e91-2a42-393e-f56e-6eae1a1c8ff3@xn--ko-wla.pl>
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
In-Reply-To: <b8c79e91-2a42-393e-f56e-6eae1a1c8ff3@xn--ko-wla.pl>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-SPAM-LEVEL: Spam detection results:  0
 AWL 0.005 Adjusted score from AWL reputation of From: address
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 NICE_REPLY_A           -0.001 Looks like a legit reply (A)
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_PASS               -0.001 SPF: sender matches SPF record
 URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See
 http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more
 information. [proxmox.com]
Subject: Re: [pve-devel] Some translation strings missing
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
X-List-Received-Date: Tue, 04 May 2021 07:12:03 -0000

Hi!

On 04.05.21 07:57, Daniel Ko=C4=87 wrote:
> I just finished full Polish translation, but found that some strings
> can't be translated. I made a quick search and it looks like some of
> them are not yet gettextized:
>=20
> $ grep -r -e "fieldLabel: '" -e "text: '" * | grep -v gettext | grep -v=

> "do not localize" | wc -l
> 228

Some of those are things like "OSD" or "Ceph" which cannot be translated,=20

some are where one probably could argue for and some are def. just missed=
=2E

>=20
> (It includes PBS and PMG messages, since all the translation messages
> are merged into one file eventually.)
>=20
> Is it possible to make a patch which fixes it?

Do you want to take a shot at this and send a patch? It shouldn't be too =
hard,
relatively speaking.

https://pve.proxmox.com/wiki/Developer_Documentation#Working_on_the_code

>=20
> This list is not complete, there are some other missing messages like:
>=20
>   * tooltip for documentation link for PVE and PMG (PBS does not have
>     this tip)
>   * "Subscription" section title on PBS dashboard
>   * Ceph installation wizard text

The latter was not made a gettext as it's a long text, really different
from the other classic field or button label texts. It changed a few time=
s
already, and it's way harder to review for correctness. Further, we
currently cannot detect gettext instances spanning over multiple lines, s=
o
the parser would need adaption.
That's not saying I'd reject making it a gettext in general, just stating=

the reasoning for initially not doing so.

>=20
> It would be great to make them also translatable.
>=20

cheers,
Thomas