From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <pve-devel-bounces@lists.proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 4E3711FF168 for <inbox@lore.proxmox.com>; Tue, 21 Jan 2025 11:37:12 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 7163A6660; Tue, 21 Jan 2025 11:37:08 +0100 (CET) Message-ID: <01858afc-d11e-4890-9fd2-30643c607e82@proxmox.com> Date: Tue, 21 Jan 2025 11:36:21 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>, Hannes Duerr <h.duerr@proxmox.com> References: <20250121100415.64884-1-h.duerr@proxmox.com> <20250121100415.64884-5-h.duerr@proxmox.com> Content-Language: en-US From: Dominik Csapak <d.csapak@proxmox.com> In-Reply-To: <20250121100415.64884-5-h.duerr@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.020 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [multi-user.target, network.target, b.com, debian.com, a.com] Subject: Re: [pve-devel] [PATCH pve-nvidia-vgpu-helper v2 4/4] debian: add and install nvidia-vgpu systemd template unit file X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com> Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com> mhmm not sure if it's so good to reuse the exiting name of the nvidia service for this. also not sure how systemd likes it if there is a service 'foo.service' and a template 'foo@.service' (though my guess would be that it's not that big of an issue) i'd like to seee a distinct name for this (maybe even with pve prefix) like: pve-nvidia-sriov@.service Then it's clear where it comes from and what it's for (vgpud is an nvidia daemon that does not really has anything to do with what this does) Or do you have any objections to that? also, would it make sense to add a --- ConditionPathExists=/usr/lib/nvidia/sriov-manage --- too? otherwise users that enable it accidentally or too early run into an ugly error (though that can be desired too) On 1/21/25 11:04, Hannes Duerr wrote: > Signed-off-by: Hannes Duerr <h.duerr@proxmox.com> > --- > debian/nvidia-vgpud@.service | 12 ++++++++++++ > debian/rules | 3 +++ > 2 files changed, 15 insertions(+) > create mode 100644 debian/nvidia-vgpud@.service > > diff --git a/debian/nvidia-vgpud@.service b/debian/nvidia-vgpud@.service > new file mode 100644 > index 0000000..b3c1220 > --- /dev/null > +++ b/debian/nvidia-vgpud@.service > @@ -0,0 +1,12 @@ > +[Unit] > +Description=Enable NVIDIA SR-IOV for PCI ID %i > +After=network.target nvidia-vgpud.service nvidia-vgpu-mgr.service > +Before=pve-guests.service > + > +[Service] > +Type=oneshot > +ExecStartPre=/bin/sleep 5 > +ExecStart=/usr/lib/nvidia/sriov-manage -e %i > + > +[Install] > +WantedBy=multi-user.target > diff --git a/debian/rules b/debian/rules > index 218df65..fe9a05d 100755 > --- a/debian/rules > +++ b/debian/rules > @@ -6,3 +6,6 @@ > > %: > dh $@ > + > +override_dh_installsystemd: > + dh_installsystemd --no-start --no-enable --name nvidia-vgpud@ nvidia-vgpud@.service _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel