From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id 297D31FF0B3 for ; Fri, 25 Sep 2026 12:17:38 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id E9613216A2; Fri, 25 Sep 2026 12:17:37 +0200 (CEST) Message-ID: <0120fe7b-8ec5-4ca8-bb6e-7e3d3cd9a91d@proxmox.com> Date: Fri, 25 Sep 2026 12:17:34 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Christian Ebner Subject: Re: [PATCH proxmox-backup v3 2/3] fix #6990: server: drop verify state on push job To: Jakob Klocker , pbs-devel@lists.proxmox.com References: <20260922131110.313302-1-j.klocker@proxmox.com> <20260922131110.313302-3-j.klocker@proxmox.com> Content-Language: en-US, de-DE In-Reply-To: <20260922131110.313302-3-j.klocker@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1790331454764 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.626 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: OA52F2GZPRI5JSI7EAK3QGATQPU57PS2 X-Message-ID-Hash: OA52F2GZPRI5JSI7EAK3QGATQPU57PS2 X-MailFrom: c.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 9/22/26 3:11 PM, Jakob Klocker wrote: > When pushing a snapshot the target manifest is recreated from the source > manifest, copying its verify_state. As with pull, this makes the pushed > snapshot appear verified on the remote without its stored copy having > been checked there. > Strip verify_state after copying the unprotected section so the pushed > snapshot is verified independently on the target. > > Link: https://bugzilla.proxmox.com/show_bug.cgi?id=6990 > Signed-off-by: Jakob Klocker As on the last version of the patches, consider: Reviewed-by: Christian Ebner > --- > src/server/push.rs | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/src/server/push.rs b/src/server/push.rs > index 487fd91e3..0b754ac2b 100644 > --- a/src/server/push.rs > +++ b/src/server/push.rs > @@ -1453,6 +1453,13 @@ pub(crate) async fn push_snapshot( > } else { > target_manifest.signature = source_manifest.signature.clone(); > }; > + > + if let Some(unprotected) = target_manifest.unprotected.as_object_mut() { > + unprotected.remove("verify_state"); > + } else { > + bail!("Encountered unexpected manifest without 'unprotected' section."); > + } > + > // FIXME: replace me with to_data_blob once there is an upload_blob > let manifest_string = > target_manifest.to_string(encrypt_using_key.map(|(_, config)| config).as_deref())?;