From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <0100017e795d9dc6-a172843a-b130-43c8-8bb6-8f1a5f9eeb54-000000@amazonses.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 5DF786276F for ; Thu, 20 Jan 2022 22:36:04 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 5208E29009 for ; Thu, 20 Jan 2022 22:36:04 +0100 (CET) Received: from a48-33.smtp-out.amazonses.com (a48-33.smtp-out.amazonses.com [54.240.48.33]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 71D1728FF0 for ; Thu, 20 Jan 2022 22:36:02 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=qmjwmcbdebflivjf5q7gyd5xjt54qgwu; d=nicksherlock.com; t=1642713685; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:To:Content-Type; bh=1ji1WZgj405uWDMpGKjghAgm14lDCjBTOCb8z1HjzhE=; b=egf/aTPFxP7wFPcPRtrY7IHLDggkBQHGg4w2KEfvl4gnguok/O0iTKOkRlcoswSF 78cGBILjJHvLg5PkZ9SdXY+NDFGkWj89BW/ydEQDFNibm67URYrrfnBLqdG2854is5j zQeSEnWFkFER05Crj+jJ/QL6OS+eSS3sNpUgYmFMB3vU/KZUz04mZ70d+EqwudMugBF PN8r0f9Z2GrnEaa/s+cZHoMDF4MQmAi9ayrtzi0oP73vexdZXtF3aItgPz5Qw3bRo38 e7GabJBlkp7XAhQfQRvIt/Y0SGdeM8tcd9wTuLG6RcADIZbxQ6MxP5dFYpkVUknuyjP YF6WlXNBWA== DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=ug7nbtf4gccmlpwj322ax3p6ow6yfsug; d=amazonses.com; t=1642713685; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:To:Content-Type:Feedback-ID; bh=1ji1WZgj405uWDMpGKjghAgm14lDCjBTOCb8z1HjzhE=; b=e3RdcA7sD18Eews9BSzGSoqbD0/TELeeQ1bnpS0EyY9uGJgy5BM0cNayj0brKuDe 9YD6qiam72Cmnypafxe93fiOGHvasXkpoR/8VmyPZ7iVQQ/FJsJ4ip/PlcHlfdbRkYP H7PKH8cllRCm0Wl5HqWNGTJuUlxtZEekuUSMv2d8= X-Gm-Message-State: AOAM531gfb6Jtz4vCc1+6JxXn8evh0WVl0VN5rYu35y8E0KZrG+SWyc3 i+zlAj/qqpNYxzY59ZL5X2tFntaHaeFqVF99Kdk= X-Google-Smtp-Source: ABdhPJxwDUe5zIuGLWMWBKByoYwBYYvs5JH+cJ/XiQh8I8iPd+E/8j6XvFmltcCwuHTdk3ZELXF/5Fu5slAuItBaQOk= X-Received: by 2002:a9d:75d6:: with SMTP id c22mr523320otl.273.1642713684742; Thu, 20 Jan 2022 13:21:24 -0800 (PST) MIME-Version: 1.0 References: <0100017e6f20a655-ab37d914-86d7-4a80-a82e-1293bef516b0-000000@email.amazonses.com> In-Reply-To: From: Nicholas Sherlock Date: Thu, 20 Jan 2022 21:21:25 +0000 X-Gmail-Original-Message-ID: Message-ID: <0100017e795d9dc6-a172843a-b130-43c8-8bb6-8f1a5f9eeb54-000000@email.amazonses.com> To: Proxmox VE development discussion Feedback-ID: 1.us-east-1.Zun7nGVgCINWr9mhx6IDxIE7OFgiOsHC8NqBQnS80nA=:AmazonSES X-SES-Outgoing: 2022.01.20-54.240.48.33 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.000 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain HEADER_FROM_DIFFERENT_DOMAINS 0.248 From and EnvelopeFrom 2nd level mail domains are different HTML_MESSAGE 0.001 HTML included in message RCVD_IN_DNSWL_NONE -0.0001 Sender listed at https://www.dnswl.org/, no trust RCVD_IN_MSPIKE_H2 -0.001 Average reputation (+2) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox.com, nicksherlock.com] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [pve-devel] [PATCH v2 qemu-server 0/1] pci: allow override of PCI vendor/device ids X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Jan 2022 21:36:04 -0000 On Fri, 21 Jan 2022, 4:48 am Dominik Csapak, wrote: > 2 nits left (you could send a v3, or we can fix it up, please > write what you prefer) > > * the commit message should not have lines longer than 70 characters[0] > * and the gettext is not optimal, i'd omit the 'Set ' prefix (sorry i did > not > catch it the first time), so 'Vendor ID' instead of 'Set vendor ID' > I would recommend keeping the "set" text in, because otherwise it makes it look like you can pick which host device you want to pass through by using those fields. I think it could confuse people. Happy for you to fix the patch as needed Cheers, Nick > otherwise: > > Reviewed-by: Dominik Csapak > Tested-by: Dominik Csapak > > 0: > https://pve.proxmox.com/wiki/Developer_Documentation#Commits_and_Commit_Messages > > > _______________________________________________ > pve-devel mailing list > pve-devel@lists.proxmox.com > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel > >