From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <a.lauterer@proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits))
(No client certificate requested)
by lists.proxmox.com (Postfix) with ESMTPS id 54DFA69A82
for <pve-devel@lists.proxmox.com>; Mon, 14 Mar 2022 09:20:18 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id 511F737E31
for <pve-devel@lists.proxmox.com>; Mon, 14 Mar 2022 09:19:48 +0100 (CET)
Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com
[94.136.29.106])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits))
(No client certificate requested)
by firstgate.proxmox.com (Proxmox) with ESMTPS id C231137E28
for <pve-devel@lists.proxmox.com>; Mon, 14 Mar 2022 09:19:47 +0100 (CET)
Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])
by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 690754582F
for <pve-devel@lists.proxmox.com>; Mon, 14 Mar 2022 09:19:47 +0100 (CET)
Message-ID: <00ab1f62-2a8d-bd69-8d1e-8a4be2949a8a@proxmox.com>
Date: Mon, 14 Mar 2022 09:19:46 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
Thunderbird/91.7.0
Content-Language: en-US
To: Fabian Ebner <f.ebner@proxmox.com>, pve-devel@lists.proxmox.com
References: <20220307100722.257128-1-a.lauterer@proxmox.com>
<20220307100722.257128-2-a.lauterer@proxmox.com>
<eec6e867-7570-3c16-566d-61df51de8912@proxmox.com>
<1da390da-b037-f9e0-3de2-505c0b89e5d9@proxmox.com>
<8b358d90-509b-53aa-d0f2-5d1d2a7d9845@proxmox.com>
From: Aaron Lauterer <a.lauterer@proxmox.com>
In-Reply-To: <8b358d90-509b-53aa-d0f2-5d1d2a7d9845@proxmox.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
X-SPAM-LEVEL: Spam detection results: 0
AWL 0.019 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
NICE_REPLY_A -0.001 Looks like a legit reply (A)
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
T_SCC_BODY_TEXT_LINE -0.01 -
Subject: Re: [pve-devel] [PATCH v3 manager 1/4] ui: lxc/qemu: add disk
reassign and action submenu
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
X-List-Received-Date: Mon, 14 Mar 2022 08:20:18 -0000
On 3/14/22 09:18, Fabian Ebner wrote:
> Am 11.03.22 um 15:38 schrieb Aaron Lauterer:
>> On 3/10/22 11:49, Fabian Ebner wrote:
>>> Am 07.03.22 um 11:07 schrieb Aaron Lauterer:
>>>> + cbindData: function() {
>>>> + let me = this;
>>>> + return {
>>>> + vmid: me.vmid,
>>>> + disk: me.disk,
>>>> + isQemu: me.type === 'qemu',
>>>> + nodename: me.nodename,
>>>> + url: `/nodes/${me.nodename}/${me.type}/${me.vmid}/`,
>>>> + };
>>>> + },
>>>> +
>>>> + cbind: {
>>>> + title: get => get('isQemu') ? gettext('Reassign disk') :
>>>> gettext('Reassign volume'),
>>>> + submitText: get => get('title'),
>>>> + qemu: '{isQemu}',
>>>> + url: '{url}',
>>>> + },
>>>> +
>>>> + submitUrl: function(url, values) {
>>>> + url += this.qemu ? 'move_disk' : 'move_volume';
>>>
>>> Why not already construct the full URL above?
>>
>> I'll see how to do that. First tests show that if I construct the
>> submitUrl directly, I need to set the 'url' at some point, even if not
>> used because the edit window does check its existence.
>>
>
> Sorry, by "above" I meant in the cbindData function, not directly above.
Yeah. In the meantime I found out, that I can also just use the `url` as it will be used if there is no `submitUrl`.